Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Aug 2018 23:24:59 +0300
From:      Vladimir Kondratyev <vladimir@kondratyev.su>
To:        AN <a.n.us@ieee.org>, freebsd-current@freebsd.org
Cc:        vbox@freebsd.org
Subject:   Re: Vbox causing host crash/reboot on 12-current
Message-ID:  <beed431a-0f89-487e-18ee-b846c81af430@kondratyev.su>
In-Reply-To: <CA%2B2zecw1Lv6A5FhDTU-qupHVVpTFvgNySD5HWO4oeCc=HzXKfg@mail.gmail.com>
References:  <CA%2B2zecyfmBrriuYOGLmbHVMV2b3R-rZKW9vetuJwXgKpUUqzmQ@mail.gmail.com> <CA%2B2zecw1Lv6A5FhDTU-qupHVVpTFvgNySD5HWO4oeCc=HzXKfg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------1619DBF8188E1D81847240A9
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi

I am sure that crashes was caused by SMAP as I am faced with them too.
I have made following patch to fix panic (attached)
Apply it to portstree and rebuild emulators/virtualbox-ose-kmod

P.S. It is POC so no arch/SMAP autodetection

On 8/7/18 6:14 PM, AN wrote:
> Update:
>
> I found the revision:
> https://svnweb.freebsd.org/base?view=revision&revision=336876
>
> Use SMAP on amd64.
>
> Could this possibly cause VBox to crash and reboot the system?  Is
> there a sysctl to disable?
>
> Thanks
>
> On Tue, Aug 7, 2018 at 10:46 AM, AN <a.n.us@ieee.org> wrote:
>> I recently started having severe instability on a workstation with
>> VirtualBox.  I'm not sure if it was caused by the recent large ports
>> update, or a recent commit that affected SMAP.  I can't seem to find
>> that revision, would someone please post it and also the workaround to
>> disable it, I would like to try it after work and see if disabling it
>> allows VBox to work.  Is anyone else seeing this effect with Vbox?
>>
>> What I'm seeing is that as soon as a VM is started it reboots the
>> host, totally reproducible every time.  I tried to rebuild VBox and
>> kmod, and also some qt5 ports but still not working.  Any help is
>> appreciated, thanks for reading.
>>
>> Regards
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"



--------------1619DBF8188E1D81847240A9
Content-Type: text/x-patch;
 name="vbox-smap.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="vbox-smap.patch"

Index: emulators/virtualbox-ose/files/patch-smap
===================================================================
--- emulators/virtualbox-ose/files/patch-smap	(nonexistent)
+++ emulators/virtualbox-ose/files/patch-smap	(working copy)
@@ -0,0 +1,36 @@
+--- src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c.orig	2018-08-08 22:32:59.741196000 +0300
++++ src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c	2018-08-08 22:52:49.842726000 +0300
+@@ -44,6 +44,7 @@
+ #include <sys/fcntl.h>
+ #include <sys/conf.h>
+ #include <sys/uio.h>
++#include <machine/cpufunc.h>
+ 
+ #include "../SUPDrvInternal.h"
+ #include <VBox/version.h>
+@@ -310,6 +311,9 @@ static int VBoxDrvFreeBSDIOCtl(struct cd
+ {
+     PSUPDRVSESSION pSession;
+     devfs_get_cdevpriv((void **)&pSession);
++    int rc;
++
++    stac();
+ 
+     /*
+      * Deal with the fast ioctl path first.
+@@ -318,9 +322,13 @@ static int VBoxDrvFreeBSDIOCtl(struct cd
+             || ulCmd == SUP_IOCTL_FAST_DO_HM_RUN
+             || ulCmd == SUP_IOCTL_FAST_DO_NOP)
+         && pSession->fUnrestricted == true)
+-        return supdrvIOCtlFast(ulCmd, *(uint32_t *)pvData, &g_VBoxDrvFreeBSDDevExt, pSession);
++        rc = supdrvIOCtlFast(ulCmd, *(uint32_t *)pvData, &g_VBoxDrvFreeBSDDevExt, pSession);
++    else
++        rc = VBoxDrvFreeBSDIOCtlSlow(pSession, ulCmd, pvData, pTd);
+ 
+-    return VBoxDrvFreeBSDIOCtlSlow(pSession, ulCmd, pvData, pTd);
++    clac();
++
++    return rc;
+ }
+ 
+ 

Property changes on: emulators/virtualbox-ose/files/patch-smap
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property

--------------1619DBF8188E1D81847240A9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?beed431a-0f89-487e-18ee-b846c81af430>