Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Oct 2015 21:40:29 +1100
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, z7dr6ut7gs@snkmail.com
Subject:   Re: svn commit: r399654 - head/astro/gpstk
Message-ID:  <5624C89D.2060407@FreeBSD.org>
In-Reply-To: <20151019103454.GA34329@FreeBSD.org>
References:  <201510191018.t9JAIClO040193@repo.freebsd.org> <20151019103454.GA34329@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 19/10/2015 9:34 PM, Alexey Dokuchaev wrote:
>> New Revision: 399654
>> > URL: https://svnweb.freebsd.org/changeset/ports/399654
>> > 
>> > Log:
>> >   astro/gpstk: Fix distinfo, Mark Unbroken
> It should'be been mentioned that submitter (previous maintainer) had
> verified the contents of the old and new tarballs, as he explained in the
> PR.  Excerpt from it required to be part of the commit log.

I don't understand? It 'shouldnt' be mentioned, but I didn't mention it,
or did you mean I 'should' have mentioned it? If so, understood.


>> > @@ -6,13 +6,13 @@ PORTVERSION=	2.5
>> >  CATEGORIES=	astro devel
>> >  MASTER_SITES=	SF
>> >  DISTNAME=	${PORTNAME}-${PORTVERSION}.src
>> > +EXTRACT_AFTER_ARGS=	--exclude .git
>> >  
>> >  MAINTAINER=	ports@FreeBSD.org
> "Having maintained this port in the past (but got pulled away for a while),
> [submitter is] willing to take it again." -- from the PR.

I missed this and committed the patch as is. I'll update it accordingly
along with a FATAL portlint error that was introduced.

>> > -SHA256 (gpstk-2.5.src.tar.gz) = c3be55ea0ea6a08c823b41c51064ab4596f6e1591dc18533816fac86f0087099
>> > -SIZE (gpstk-2.5.src.tar.gz) = 70300615
>> > +SHA256 (gpstk-2.5.src.tar.gz) = 2b70544d301a86c45b68dd9e24df8415f520c3922905274e4d5d2dcdb3234834
>> > +SIZE (gpstk-2.5.src.tar.gz) = 231183550
> I'd suggest asking upstream to properly roll their joints^tarballs next time
> they decide to make a release (that is, without .git metainfo).

That would be lovely.

> ./danfe




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5624C89D.2060407>