Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Mar 2001 10:31:58 -0600
From:      Jonathan Lemon <jlemon@flugsvamp.com>
To:        Doug Barton <DougB@DougBarton.net>
Cc:        Andrew Gallatin <gallatin@cs.duke.edu>, Jonathan Lemon <jlemon@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/mii inphy.c
Message-ID:  <20010327103158.O93687@prism.flugsvamp.com>
In-Reply-To: <3AC06C74.CAAA5567@DougBarton.net>
References:  <200103170250.f2H2oLE26064@freefall.freebsd.org> <20010320172100.A46733@grasshopper.cs.duke.edu> <3AC06C74.CAAA5567@DougBarton.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 27, 2001 at 02:33:24AM -0800, Doug Barton wrote:
> Andrew Gallatin wrote:
> > 
> > Jonathan Lemon [jlemon@FreeBSD.org] wrote:
> > > jlemon      2001/03/16 18:50:21 PST
> > >
> > >   Modified files:
> > >     sys/dev/mii          inphy.c
> > >   Log:
> > >   Really fix NWAY negotiation for the 82553 PHY.  Locking down the
> > >   media interface selection should not imply disabling NWAY negotiaton
> > >   as well.
> > 
> > This causes my older fxp's to loose the link:
> 
> 	Auto-negotiation has been broken for me since the following commit:
> 
> jlemon      2001/03/14 11:50:37 PST
> 
>   Modified files:
>     sys/dev/fxp          if_fxp.c if_fxpreg.h if_fxpvar.h 
>   Log:
>   Add some performance features to the fxp driver.  If the chip is not
>   a 82557 (e.g.: a newer chip) then:

Hmm, that's interesting.  The above mentioned commit shouldn't have 
anything to do with autonegotiate; either the driver is misidenifying
the chip, or I screwed up the register mappings.

Can you try the following tiny patch?  Then boot with -v and send me
all the relevant fxp lines.  I'll review the register mappings again
just as soon as I get home from my current trip.
--
Jonathan


Index: if_fxp.c
===================================================================
RCS file: /ncvs/src/sys/dev/fxp/if_fxp.c,v
retrieving revision 1.109
diff -u -r1.109 if_fxp.c
--- if_fxp.c    2001/03/14 19:50:35     1.109
+++ if_fxp.c    2001/03/27 16:33:35
@@ -473,6 +473,7 @@
		device_printf(dev, "PCI IDs: %04x %04x %04x %04x\n",
		    pci_get_vendor(dev), pci_get_device(dev),
		    pci_get_subvendor(dev), pci_get_subdevice(dev));
+		device_printf(dev, "Chip Type: %d\n", sc->chip);
	}

	/*

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010327103158.O93687>