From owner-p4-projects@FreeBSD.ORG  Mon Jun 22 20:13:30 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2E514106567D; Mon, 22 Jun 2009 20:13:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE1D5106567B
	for <perforce@FreeBSD.org>; Mon, 22 Jun 2009 20:13:29 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CC16E8FC1E
	for <perforce@FreeBSD.org>; Mon, 22 Jun 2009 20:13:29 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5MKDTZS058059
	for <perforce@FreeBSD.org>; Mon, 22 Jun 2009 20:13:29 GMT
	(envelope-from syl@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5MKDTlu058057
	for perforce@freebsd.org; Mon, 22 Jun 2009 20:13:29 GMT
	(envelope-from syl@FreeBSD.org)
Date: Mon, 22 Jun 2009 20:13:29 GMT
Message-Id: <200906222013.n5MKDTlu058057@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	syl@FreeBSD.org using -f
From: Sylvestre Gallon <syl@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 164896 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2009 20:13:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=164896

Change 164896 by syl@syl_atuin on 2009/06/22 20:12:52

	- Fix a bug in usb_generic for isochronous control transfer (find by Hans Petter Selasky).
	- Update test2 code.

Affected files ...

.. //depot/projects/soc2009/syl_usb/libusb-tests/transfers/test1/test1.c#6 edit
.. //depot/projects/soc2009/syl_usb/libusb-tests/transfers/test2/test2.c#6 edit
.. //depot/projects/soc2009/syl_usb/src/sys/dev/usb/usb_generic.c#6 edit

Differences ...

==== //depot/projects/soc2009/syl_usb/libusb-tests/transfers/test1/test1.c#6 (text+ko) ====

@@ -28,11 +28,8 @@
 		dev = libusb_get_device(devh);
 		ret = libusb_control_transfer(devh, 0xa1, 0x03, 0x00, 0x00, data, 2, 10);
 		printf("end tr\n");
-		if (ret == LIBUSB_TRANSFER_COMPLETED) {
-			printf("data = 0x%.2x 0x%.2x\n", data[0], data[1]);
-		} else {
-			printf("transfer failed with 0x%.8x error code\n", ret);
-		}
+		printf("data = 0x%.2x 0x%.2x\n", data[0], data[1]);
+		printf("transfer failed with 0x%.8x error code\n", ret);
 	} else {
 		fprintf(stderr, "\nNo device match or lack of permissions.\n");
 	}

==== //depot/projects/soc2009/syl_usb/libusb-tests/transfers/test2/test2.c#6 (text+ko) ====


==== //depot/projects/soc2009/syl_usb/src/sys/dev/usb/usb_generic.c#6 (text+ko) ====

@@ -1070,7 +1070,7 @@
 		if (error) {
 			return (error);
 		}
-		if (length >= sizeof(*req)) {
+		if (length != sizeof(*req)) {
 			xfer->error = USB_ERR_INVAL;
 			goto complete;
 		}