From owner-cvs-src@FreeBSD.ORG Tue Jan 17 21:50:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24C7516A422; Tue, 17 Jan 2006 21:50:39 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14FDF43D45; Tue, 17 Jan 2006 21:50:31 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5DC0B.dip.t-dialin.net [84.165.220.11]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id k0HLhrYq033285; Tue, 17 Jan 2006 22:43:54 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id k0HLoSEs008887; Tue, 17 Jan 2006 22:50:29 +0100 (CET) (envelope-from Alexander@Leidinger.net) Date: Tue, 17 Jan 2006 22:50:28 +0100 From: Alexander Leidinger To: Alfred Perlstein Message-ID: <20060117225028.2f014c1e@Magellan.Leidinger.net> In-Reply-To: <200601171729.k0HHT3Ng026618@repoman.freebsd.org> References: <200601171729.k0HHT3Ng026618@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 1.9.100 (GTK+ 2.8.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vnops.c src/sys/fs/msdosfs msdosfs_denode.c src/sys/fs/ntfs ntfs_vnops.c src/sys/fs/nwfs nwfs_node.c src/sys/fs/smbfs smbfs_node.c src/sys/fs/udf udf_vnops.c src/sys/isofs/cd9660 cd9660_node.c src/sys/nfsclient ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2006 21:50:39 -0000 On Tue, 17 Jan 2006 17:29:03 +0000 (UTC) Alfred Perlstein wrote: > alfred 2006-01-17 17:29:03 UTC > > FreeBSD src repository > > Modified files: > sys/fs/hpfs hpfs_vnops.c > sys/fs/msdosfs msdosfs_denode.c > sys/fs/ntfs ntfs_vnops.c > sys/fs/nwfs nwfs_node.c > sys/fs/smbfs smbfs_node.c > sys/fs/udf udf_vnops.c > sys/isofs/cd9660 cd9660_node.c > sys/nfsclient nfs_node.c > Log: > I ran into an nfs client panic a couple of times in a row over the > last few days. I tracked it down to the fact that nfs_reclaim() > is setting vp->v_data to NULL _before_ calling vnode_destroy_object(). > After silence from the mailing list I checked further and discovered > that ufs_reclaim() is unique among FreeBSD filesystems for calling > vnode_destroy_object() early, long before tossing v_data or much > of anything else, for that matter. The rest, including NFS, appear > to be identical, as if they were just clones of one original routine. "Clones" as in identical and could be refactored into one function? > The enclosed patch fixes all file systems in essentially the same > way, by moving the call to vnode_destroy_object() to early in the > routine (before the call to vfs_hash_remove(), if any). I have > only tested NFS, but I've now run for over eighteen hours with the > patch where I wouldn't get past four or five without it. Do you think this panic can be triggered by e.g. letting rhytmbox run over a lot of music files on 2 msdosfs partitions to update the music library? Bye, Alexander. -- It's not a bug, it's tradition! http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 WL http://www.amazon.de/exec/obidos/registry/1FZ4DTHQE9PQ8/ref=wl_em_to/