From owner-freebsd-net@FreeBSD.ORG  Sun Dec 14 03:23:02 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 94CE216A4CE
	for <net@FreeBSD.org>; Sun, 14 Dec 2003 03:23:02 -0800 (PST)
Received: from smtp003.mail.ukl.yahoo.com (smtp003.mail.ukl.yahoo.com
	[217.12.11.34])	by mx1.FreeBSD.org (Postfix) with SMTP id 1992643D1D
	for <net@FreeBSD.org>; Sun, 14 Dec 2003 03:23:01 -0800 (PST)
	(envelope-from NateBSD@yahoo.it)
Received: from unknown (HELO LapBSD.MetalZone) (natebsd@80.182.192.142 with
	plain)
	by smtp003.mail.ukl.yahoo.com with SMTP; 14 Dec 2003 11:22:59 -0000
From: Nate Grey <NateBSD@yahoo.it>
To: Maxim Konovalov <maxim@macomnet.ru>
Date: Sun, 14 Dec 2003 12:23:01 +0000
User-Agent: KMail/1.5.4
References: <200312131149.44582.NateBSD@yahoo.it>
	<20031213214424.E42015@news1.macomnet.ru>
In-Reply-To: <20031213214424.E42015@news1.macomnet.ru>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200312141223.01385.NateBSD@yahoo.it>
cc: net@FreeBSD.org
Subject: Re: Fwd: 5.2-RC + ipfw
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2003 11:23:02 -0000

On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
> Please try an enclosed patch or put a whitespace right after the '('
> before '\'.
>
> Index: ipfw2.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> retrieving revision 1.42
> diff -u -r1.42 ipfw2.c
> --- ipfw2.c	31 Oct 2003 18:31:55 -0000	1.42
> +++ ipfw2.c	13 Dec 2003 18:42:18 -0000
> @@ -2901,15 +2901,14 @@
>  		goto done;
>
>  #define OR_START(target)					\
> -	if (ac && (*av[0] == '(' || *av[0] == '{')) {		\
> +	if (ac && (						\
> +	    !strncmp(*av, "(", strlen(*av)) ||			\
> +	    !strncmp(*av, "{", strlen(*av)) )) {		\
>  		if (open_par)					\
>  			errx(EX_USAGE, "nested \"(\" not allowed\n"); \
>  		prev = NULL;					\
>  		open_par = 1;					\
> -		if ( (av[0])[1] == '\0') {			\
> -			ac--; av++;				\
> -		} else						\
> -			(*av)++;				\
> +		ac--; av++;					\
>  	}							\
>  	target:							\
>
> %%%

Problem solved just adding a whitespace. Should I apply the patch anyway?