Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Mar 1998 11:35:19 +0900 (JST)
From:      Michael Hancock <michaelh@cet.co.jp>
To:        Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>
Cc:        Terry Lambert <tlambert@primenet.com>, current@FreeBSD.ORG
Subject:   Re: vnode_pager: *** WARNING *** stale FS code in system 
Message-ID:  <Pine.SV4.3.95.980310111738.28539A-100000@parkplace.cet.co.jp>
In-Reply-To: <199803092359.CAA03508@tejblum.dnttm.rssi.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
I think vnode_pager_generic_(put|get)pages should be moved to
vfs_default.c and renamed vop_std(put|get)pages.  It would need to be
modified to accept ap instead of 4 components of ap.

Terry is trying to make it more visible to fs implementors so that they
take the time to understand how to make VM friendly implementations.  The
"XXX - wimp out ..." comment is also added for extra emphasis.  This
comment should be taken out and replaced by a comment explaining what a VM
friendly (get|put)pages should do.

I think vfs_default.c is visible enough.

This is a form discussion, the substance is the same. My personal opinion
is that it doesn't belong vnode_pager.c because it will tend to be ignored
by fs implementors.

Regards,


Mike Hancock



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.95.980310111738.28539A-100000>