Date: Tue, 16 Jul 2019 16:44:45 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Brooks Davis <brooks@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350049 - head/contrib/amd/amd Message-ID: <20190716204445.qyhccsp6cijkxslk@mutt-hbsd> In-Reply-To: <6ddf37a1-3b1a-2401-a338-36b6c8b9947d@FreeBSD.org> References: <201907161603.x6GG38oZ020228@repo.freebsd.org> <20190716194454.odytcdjtlduliz6l@mutt-hbsd> <6ddf37a1-3b1a-2401-a338-36b6c8b9947d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4xnewste4utnug75 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 01:41:06PM -0700, John Baldwin wrote: > On 7/16/19 12:44 PM, Shawn Webb wrote: > > On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote: > >> Author: brooks > >> Date: Tue Jul 16 16:03:08 2019 > >> New Revision: 350049 > >> URL: https://svnweb.freebsd.org/changeset/base/350049 > >> > >> Log: > >> Fix two mismatches between function declaration and definition. > >> =20 > >> In both cases, function pointer arguments were inconsistently declar= ed > >> and the result worked because of C's odd rules around function point= er > >> (de)references. With a stricter compiler these fail to compile. > >=20 > > And, with CFI applied to the kernel, would cause a panic. :) > >=20 > > Good catch and thanks for the great work! >=20 > How would an incorrect function prototype in userland cause a kernel pani= c? Another good catch! I misread the intent of the patch. Sorry for the line noise. --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --4xnewste4utnug75 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0uNzcACgkQ/y5nonf4 4fpwPxAAo3YWTwjFpQ7wOTZNnZXbT/FbG/0BLpfZMGgoXFDtaHPv8M23g5ha6g3T BJcV7gCB9nL0fUN86qP0Q64eurm2BoCEJx9p6y6YOMHSPddRb3HZ76t0KrIkOgP0 KQf4eHLM7sX/1jRhdzaRk96rOI8Kq9BgkSc0AKiBg7IGIDf5eW+TLWjm/Hdkozvn ms1dx6YLtBD9IzQPadsbcQ8THEhkP34JnsY+A8gZLoXRUbfPbNTzJ0MAt/aj6n2h 2cS4UQpGaQf2s2GL4oXKmz8cjrl5MsVC+/MnB0APruvoW8KNqgNOFW6uxncaKBtO a1Lfd71Im5S4t9pGk6jdoOux8cj+OtaeYww/onKhCnZdkZAFfg4cfyKbHRLF+HX3 iAWbJmjj/h5+FMlnID6l8Net6ExWbcZag3yiJsh9fwD8lDrboHAIdXqhYqh1xz98 n7+wdW2sogwgyMI/9hFlEPlDGFUwUts3p04t9p5rARHkKCCBDbKz8FpFZWy7JC/w 15uJl6QhXQfbuegm5sgMjjpDvmbTk/sUQb6bohwBJ95UWp97RcVKwz34MZ5dnErj G2URwEJTXtA/nif6fGdgttAoQXTLHHh7egH46LGSP1q6VFPSU8BML/2F9QM99CrN 9z9Gqd26XAqZv6ZLnx/cI/UcWKgJhjdqVyWJxEQ3U559DHf6qRw= =xZj2 -----END PGP SIGNATURE----- --4xnewste4utnug75--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190716204445.qyhccsp6cijkxslk>