From owner-svn-ports-all@freebsd.org Mon Sep 4 04:31:46 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9E1CE12671; Mon, 4 Sep 2017 04:31:46 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFCE264576; Mon, 4 Sep 2017 04:31:45 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id ad64db5b TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sun, 3 Sep 2017 22:31:38 -0600 (MDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r449195 - head/security/py-cryptography From: Adam Weinberger In-Reply-To: <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> Date: Sun, 3 Sep 2017 22:31:32 -0600 Cc: Rene Ladan , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "python@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9B4070BD-B841-40F8-9985-477457D9039D@adamw.org> References: <201709031028.v83AS09e027702@repo.freebsd.org> <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> To: koobs@FreeBSD.org X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 04:31:46 -0000 > On 3 Sep, 2017, at 21:29, Kubilay Kocak wrote: >=20 > On 9/3/17 8:28 PM, Rene Ladan wrote: >> Author: rene >> Date: Sun Sep 3 10:28:00 2017 >> New Revision: 449195 >> URL: https://svnweb.freebsd.org/changeset/ports/449195 >>=20 >> Log: >> security/py-cryptography: remove support for expired Python 3.3 >>=20 >> Modified: >> head/security/py-cryptography/Makefile >>=20 >> Modified: head/security/py-cryptography/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/security/py-cryptography/Makefile Sun Sep 3 10:12:26 2017 = (r449194) >> +++ head/security/py-cryptography/Makefile Sun Sep 3 10:28:00 2017 = (r449195) >> @@ -35,8 +35,6 @@ RUN_DEPENDS+=3D = ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/p >>=20 >> .if ${PYTHON_REL} < 3300 >> RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34 >> -.elif ${PYTHON_REL} < 3400 >> -RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum34 >> .endif >>=20 >> post-install: >>=20 >=20 > Please revert this change: >=20 > - It is *meant* to include all versions below 3.4, including 2.7 > - It is not necessary to delete when a python language port version is > removed. The block still semantically and correctly declares the valid > version dependency requirements from the upstream, independently from > what the tree has at any point in time. >=20 > Also, if you could, please ask/talk to python maintainers and/or = python@ > with regard to port deprecation/deletions before committing. It is not > always entirely obvious or explicit what is the correct thing to do is > without fully understanding the versions support and semantics = completely. Python 2.7 needs py-enum34, not py3-enum34, and that block was left in. = Unless I'm missing something, Ren=C3=A9's change should have no impact = on python 2.7, no? The argument against your second point is that sortof-but-not-really = supporting expired versions of ports is a disservice to both porters and = end-users, when it is unclear what is and isn't expected to work. The = precedent these days is that expired ports are purged. Your final point is well-taken, but I urge you to do the same. EXPIRED = purges are tricky, and Ren=C3=A9 makes them happen every month. If ports = marked for expiration need to be retained or handled specially, reach = out to portmgr! # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org