From owner-freebsd-current@FreeBSD.ORG Wed Sep 14 22:01:28 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C15316A41F for ; Wed, 14 Sep 2005 22:01:28 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFD4143D64 for ; Wed, 14 Sep 2005 22:01:23 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Wed, 14 Sep 2005 18:17:01 -0400 From: John Baldwin To: Gavin Atkinson Date: Wed, 14 Sep 2005 17:11:00 -0400 User-Agent: KMail/1.8 References: <200508311636.49278.jhb@FreeBSD.org> <20050904235509.J31032@ury.york.ac.uk> <1125922064.75892.20.camel@buffy.york.ac.uk> In-Reply-To: <1125922064.75892.20.camel@buffy.york.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509141711.01324.jhb@FreeBSD.org> Cc: current@freebsd.org Subject: Re: [PATCH] Locking fixes for tl(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 22:01:28 -0000 On Monday 05 September 2005 08:07 am, Gavin Atkinson wrote: > On Mon, 2005-09-05 at 00:01 +0100, Gavin Atkinson wrote: > > On Sun, 4 Sep 2005, Gavin Atkinson wrote: > > > On Wed, 31 Aug 2005, John Baldwin wrote: > > >> Patch fixes locking for tl(4) and marks it MPSAFE. Please test, > > >> thanks! > > >> > > >> http://www.FreeBSD.org/~jhb/patches/tl_locking.patch > > > > > > Doesn't work, I'm afraid. Panic on attach: > > > > ... because tl_hardreset() is called before sc->tl_ifp is allocated. I'm > > recompiling now, having moved the if_alloc and related code to before the > > first hardreset() call. > > The attached patch has survived pan average amount of network activity > overnight. It's basically your original patch, but with a slight > rearrangement in tl_attach() to move the if_alloc() call earlier. I'll probably just leave the conditional asserts out altogether as that's what I've done with all the other drivers I've committed and leave if_alloc() where it is. Thanks for testing! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org