Date: Mon, 8 Aug 2005 23:48:29 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 81692 for review Message-ID: <200508082348.j78NmT44062420@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=81692 Change 81692 by rwatson@rwatson_peppercorn on 2005/08/08 23:47:53 Several XXX's that don't need to be. Affected files ... .. //depot/projects/netsmp/src/sys/net/if.c#11 edit Differences ... ==== //depot/projects/netsmp/src/sys/net/if.c#11 (text+ko) ==== @@ -1279,9 +1279,8 @@ if (error) return (error); /* - * XXXRW: Currently, no driver owned flags pass the - * IFF_CANTCHANGE check, so we don't need special handling - * here yet. + * Currently, no driver owned flags pass the IFF_CANTCHANGE + * check, so we don't need special handling here yet. */ new_flags = (ifr->ifr_flags & 0xffff) | (ifr->ifr_flagshigh << 16); @@ -1625,7 +1624,7 @@ * The "pflag" argument can specify a permanent mode flag, * such as IFF_PPROMISC for promiscuous mode; should be 0 if none. * - * XXXRW: Only to be used on stack-owned flags, not driver-owned flags. + * Only to be used on stack-owned flags, not driver-owned flags. */ static int if_setflag(struct ifnet *ifp, int flag, int pflag, int *refcount, int onswitch) @@ -2273,10 +2272,6 @@ ifp->if_obytes += m->m_pkthdr.len + adjust; if (m->m_flags & (M_BCAST|M_MCAST)) ifp->if_omcasts++; - /* - * XXXRW: Technically, we'd like the driver to do this to - * avoid races. - */ active = ifp->if_drv_flags & IFF_DRV_OACTIVE; } _IF_ENQUEUE(ifq, m);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508082348.j78NmT44062420>