Date: Mon, 20 Feb 2006 12:24:17 -0600 From: "Jeremy Messenger" <mezz7@cox.net> To: "Babak Farrokhi" <babak@farrokhi.net> Cc: freebsd-gnome@freebsd.org Subject: Re: WITHOUT_DEBUG flag for x11-toolkits/gtk20 Message-ID: <op.s5aaqrlu9aq2h7@mezz.mezzweb.com> In-Reply-To: <op.s498i8hu9aq2h7@mezz.mezzweb.com> References: <001101c6362c$21b97120$eb0ba8c0@ELF> <op.s498i8hu9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 20 Feb 2006 11:36:34 -0600, Jeremy Messenger <mezz7@cox.net> wrote:
> On Mon, 20 Feb 2006 08:44:14 -0600, Babak Farrokhi <babak@farrokhi.net>
> wrote:
>
>> Folks,
>>
>> I have always been wondering why this port does not support standard
>> WITHOUT_DEBUG flag (as many ports support this flag, and once you set
>> WITH_DEBUG=no in /etc/make.conf, those ports while enable debugging
>> instead!). So I just added this simple modification to the Makefile to
>> honor
>> the WITHOUT_DEBUG knob. (I am not sure, maybe there was a good reason
>> for
>> using WITH_DEBUG instead of WITHOUT_DEBUG).
>>
>> --- gtk20.patch begins here ---
>> diff -ruN gtk20.orig/Makefile gtk20/Makefile
>> --- gtk20.orig/Makefile Mon Feb 20 17:48:23 2006
>> +++ gtk20/Makefile Mon Feb 20 17:52:25 2006
>> @@ -51,6 +51,11 @@
>> # on the command-line.
>> # Set to minimum if you want to send in a backtrace; set # to yes if
>> you
>> want to know what gtk thinks it's doing.
>> +.if defined(WITHOUT_DEBUG)
>> +.if ${WITHOUT_DEBUG:L} == "yes"
>> +WITH_DEBUG= no
>> +.endif
>> +.endif
>> .if defined(WITH_DEBUG)
>> .if ${WITH_DEBUG:L} == "no"
>> CONFIGURE_ARGS+= --enable-debug=no
>> --- gtk20.patch ends here ---
>>
>>
>> Any opinions?
>
> Making sense for add WITHOUT_DEBUG, but how about this patch?
>
> http://people.freebsd.org/~mezz/diff/gtk20.diff
It has been committed, thanks for submitted!
Cheers,
Mezz
> Cheers,
> Mezz
>
>> --
>> Babak Farrokhi
>> babak@farrokhi.net
--
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.s5aaqrlu9aq2h7>