From owner-freebsd-gnome@FreeBSD.ORG  Mon Feb 20 18:22:08 2006
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
X-Original-To: freebsd-gnome@freebsd.org
Delivered-To: freebsd-gnome@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DC7C916A420
	for <freebsd-gnome@freebsd.org>; Mon, 20 Feb 2006 18:22:08 +0000 (GMT)
	(envelope-from mezz7@cox.net)
Received: from centrmmtao03.cox.net (centrmmtao03.cox.net [70.168.83.81])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 460FE43D45
	for <freebsd-gnome@freebsd.org>; Mon, 20 Feb 2006 18:22:08 +0000 (GMT)
	(envelope-from mezz7@cox.net)
Received: from mezz.mezzweb.com ([68.103.32.140]) by centrmmtao03.cox.net
	(InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP
	id <20060220182202.QSCL613.centrmmtao03.cox.net@mezz.mezzweb.com>;
	Mon, 20 Feb 2006 13:22:02 -0500
To: "Babak Farrokhi" <babak@farrokhi.net>
References: <001101c6362c$21b97120$eb0ba8c0@ELF>
	<op.s498i8hu9aq2h7@mezz.mezzweb.com>
Message-ID: <op.s5aaqrlu9aq2h7@mezz.mezzweb.com>
From: "Jeremy Messenger" <mezz7@cox.net>
Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Date: Mon, 20 Feb 2006 12:24:17 -0600
In-Reply-To: <op.s498i8hu9aq2h7@mezz.mezzweb.com>
User-Agent: Opera M2/8.52 (Linux, build 1631)
Cc: freebsd-gnome@freebsd.org
Subject: Re: WITHOUT_DEBUG flag for x11-toolkits/gtk20
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Feb 2006 18:22:09 -0000

On Mon, 20 Feb 2006 11:36:34 -0600, Jeremy Messenger <mezz7@cox.net> wrote:

> On Mon, 20 Feb 2006 08:44:14 -0600, Babak Farrokhi <babak@farrokhi.net>  
> wrote:
>
>> Folks,
>>
>> I have always been wondering why this port does not support standard
>> WITHOUT_DEBUG flag (as many ports support this flag, and once you set
>> WITH_DEBUG=no in /etc/make.conf, those ports while enable debugging
>> instead!). So I just added this simple modification to the Makefile to  
>> honor
>> the WITHOUT_DEBUG knob. (I am not sure, maybe there was a good reason  
>> for
>> using WITH_DEBUG instead of WITHOUT_DEBUG).
>>
>> --- gtk20.patch begins here ---
>> diff -ruN gtk20.orig/Makefile gtk20/Makefile
>> --- gtk20.orig/Makefile	Mon Feb 20 17:48:23 2006
>> +++ gtk20/Makefile	Mon Feb 20 17:52:25 2006
>> @@ -51,6 +51,11 @@
>>  # on the command-line.
>>  # Set to minimum if you want to send in a backtrace; set  # to yes if  
>> you
>> want to know what gtk thinks it's doing.
>> +.if defined(WITHOUT_DEBUG)
>> +.if ${WITHOUT_DEBUG:L} == "yes"
>> +WITH_DEBUG=	no
>> +.endif
>> +.endif
>>  .if defined(WITH_DEBUG)
>>  .if ${WITH_DEBUG:L} == "no"
>>  CONFIGURE_ARGS+=	--enable-debug=no
>> --- gtk20.patch ends here ---
>>
>>
>> Any opinions?
>
> Making sense for add WITHOUT_DEBUG, but how about this patch?
>
> http://people.freebsd.org/~mezz/diff/gtk20.diff

It has been committed, thanks for submitted!

Cheers,
Mezz

> Cheers,
> Mezz
>
>> --
>> Babak Farrokhi
>> babak@farrokhi.net


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org