Date: Fri, 12 Feb 2010 09:51:04 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: andrew@fubar.geek.nz Cc: freebsd-arm@FreeBSD.org, rpaulo@FreeBSD.org Subject: Re: New S3C24x0 patch Message-ID: <20100212.095104.655406241961872938.imp@bsdimp.com> In-Reply-To: <20100212151043.2e62ca78@fubar.geek.nz> References: <20100211223402.621a8c89@fubar.geek.nz> <4B7409B2.3040107@freebsd.org> <20100212151043.2e62ca78@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20100212151043.2e62ca78@fubar.geek.nz> Andrew Turner <andrew@fubar.geek.nz> writes: : On Thu, 11 Feb 2010 13:44:18 +0000 : Rui Paulo <rpaulo@freebsd.org> wrote: : > This looks good. Before this can be committed you need to: : > * fix the lines passing the 80 column mark : > * remove debugging printfs : I've fixed these problems. There is a new patch at [1]. : : Andrew : : [1] : http://fubar.geek.nz/files/freebsd/s3c2xx0/freebsd-s3c24x0-20100212.diff Hey Andrew, These patches look better. They are looking pretty good, but I'd like a few days to look them over and comment on them. There's a number of little things I'd like to see fixed and maybe one or two big things (or maybe not, I just need to think through some of the stuff I saw). Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100212.095104.655406241961872938.imp>