From owner-freebsd-current@FreeBSD.ORG  Wed Jun 27 19:12:25 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E56371065679;
	Wed, 27 Jun 2012 19:12:24 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 9960F8FC17;
	Wed, 27 Jun 2012 19:12:24 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:1c1d:425:65f1:4fac] (unknown
	[IPv6:2001:7b8:3a7:0:1c1d:425:65f1:4fac])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id DD8035C59;
	Wed, 27 Jun 2012 21:12:17 +0200 (CEST)
Message-ID: <4FEB5B0E.8020009@FreeBSD.org>
Date: Wed, 27 Jun 2012 21:12:14 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:14.0) Gecko/20120619 Thunderbird/14.0
MIME-Version: 1.0
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
References: <4FE9B01C.30306@yandex.ru>
In-Reply-To: <4FE9B01C.30306@yandex.ru>
X-Enigmail-Version: 1.5a1pre
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers <freebsd-hackers@freebsd.org>,
	Doug Rabson <dfr@freebsd.org>,
	freebsd-current <freebsd-current@freebsd.org>,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>, Andriy Gapon <avg@FreeBSD.org>
Subject: Re: [CFC/CFT] large changes in the loader(8) code
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2012 19:12:25 -0000

On 2012-06-26 14:50, Andrey V. Elsukov wrote:
> Some time ago i have started reading the code in the sys/boot.
> Especially i'm interested in the partition tables handling.
> I found several problems:
> 1. There are several copies of the same code in the libi386/biosdisk.c
> and common/disk.c, and partially libpc98/biosdisk.c.
> 2. ZFS probing is very slow, because the ZFS code doesn't know how many
> disks and partitions the system has:
> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=148296
> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=161897
> 3. The GPT support doesn't check CRC and even doesn't know anything
> about the secondary GPT header/table.
> 
> So, i have created the branch and committed the changes:
> 	http://svnweb.freebsd.org/base/user/ae/bootcode/
> The patch is here:
> 	http://people.freebsd.org/~ae/boot.diff

FWIW, I verified it compiles OK with clang, and especially boot2's size
isn't increased at all.

It would be nice if you could check it with clang now and again, before
you finally merge this project into head.