From owner-svn-src-head@freebsd.org Tue Oct 17 15:32:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3861AE3D152; Tue, 17 Oct 2017 15:32:38 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B04AC70DD2; Tue, 17 Oct 2017 15:32:37 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x234.google.com with SMTP id n69so2492343lfn.2; Tue, 17 Oct 2017 08:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/FiyDSpd4oc74ZpeqkVSjXv50uIQHYS4OFidTh7H5VY=; b=gytqSsllE8JkRghE53XxMjodg6HaXtpGrkEAsR2jnjlOdLeFFyaUKbFST6av8cXhrV 4gTBv3W9mvR2LAXrFkH3/rY4bRgPbOYM/XlQVf82OrFuv6kk7Ltx7ymCsQCUkGCuoW4O JsuoIKSayjIGL+/3OE/2Q3KPZZtoiRFYhPIOqbX+jQi7x5vNdohX+FyTpQjXLi1hYzqv zWEP+XHfbVlTA3uL05dz262NJS3ywl1P7ylM5k/no4QZqUB80+fT/mLen0N+7r3j4Our /qhAH7eHYOi5tTLvwqbTV/JIOXH/MAIG3WkDFaokH5ke1DLcAyfhD0BtDGXJkYcvh757 0ZTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/FiyDSpd4oc74ZpeqkVSjXv50uIQHYS4OFidTh7H5VY=; b=VxfFSL5qqedruNmJbr+cqqef+ZNrgNZfxv8Ic8TaJ0L7BmqyhcwUBa8Lt/GV7bn3p7 M2MgPLIuqvxOCJlzF0VF4RSQf1C42Kth2iKUZPDO6VIob6JmdFAtBJpV0z+uTCpiJ9t/ EQbyWTwoiNfzEDAGk+ABrUTE5NHH0IDajHgqEda40Pjf5Sxy4y/70/g+p4H2M0YcQUXr M2WFFi6/kWNBMfpEM/pf+mDkIN8L+YoNZtXqI8+Aq49WXw89ZVLktSao5Oahglb95h90 XtolU/rkF8FoiNfegQ4zqz4+XonZS0hv1d8z+otlb0TXcZ9F63FH9QYH5N4QljC5g47R BkfA== X-Gm-Message-State: AMCzsaX3wGDP7jdlpkWWo/VF3dAzIJc/kcnT+BecO23cZyjChCJEFrEe gnC420Ui+LJsI7d/X8ZF2AteEOLvIJ97zW2VEFo= X-Google-Smtp-Source: ABhQp+Q/ofkqBKTOq8e1G9KPA58U9VtHjGn6tgZvy7jQe83HmUouKMyLC2evYH2agcdwuZiTfLJEpL9lpXsjpgwwFOw= X-Received: by 10.25.87.143 with SMTP id l137mr2619062lfb.193.1508254354963; Tue, 17 Oct 2017 08:32:34 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.93.24 with HTTP; Tue, 17 Oct 2017 08:32:34 -0700 (PDT) In-Reply-To: <201710170115.v9H1FDbU046661@repo.freebsd.org> References: <201710170115.v9H1FDbU046661@repo.freebsd.org> From: Alan Somers Date: Tue, 17 Oct 2017 09:32:34 -0600 X-Google-Sender-Auth: wodR_bJF9S3jWelLnI52yQGLxFY Message-ID: Subject: Re: svn commit: r324681 - in head/etc: defaults periodic/daily To: Cy Schubert Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 15:32:38 -0000 This change defeats the anticongestion mechanism. If daily_ntpd_leapfile_background is set and 480.leapfile-ntpd runs before any other periodic script that uses anticongestion (like /usr/local/etc/periodic/security/410.pkg-audit), then the anticongestion mechanism will effectively be disabled for those later scripts. It's worth asking why you would want to do this in the background anyway. Does the submitter complain that it was too slow? The entire point of anticongestion is to slow it down. If the submitter didn't like that, he could've set anticongestion_sleeptime=0 to disable it entirely. Or was the problem that the "service ntpd onefetch" is too slow, even after the anticongestion timer ran? I doubt it, but if so then you should background just that part instead of backgrounding anticongestion too. -Alan On Mon, Oct 16, 2017 at 7:15 PM, Cy Schubert wrote: > Author: cy > Date: Tue Oct 17 01:15:13 2017 > New Revision: 324681 > URL: https://svnweb.freebsd.org/changeset/base/324681 > > Log: > Provide an option to run the anticongestion ntpd leapfile fetch in > the background. > > Original patch submitted by feld@. I added the "optional" bit. > > Submitted by: feld (original patch) > MFC after: 2 weeks > > Modified: > head/etc/defaults/periodic.conf > head/etc/periodic/daily/480.leapfile-ntpd > > Modified: head/etc/defaults/periodic.conf > ============================================================================== > --- head/etc/defaults/periodic.conf Tue Oct 17 01:12:17 2017 (r324680) > +++ head/etc/defaults/periodic.conf Tue Oct 17 01:15:13 2017 (r324681) > @@ -141,6 +141,8 @@ daily_status_mail_rejects_shorten="NO" # Shorten out > > # 480.leapfile-ntpd > daily_ntpd_leapfile_enable="YES" # Fetch NTP leapfile > +daily_ntpd_leapfile_background="NO" # Fetch NTP leapfile > + # in the background > > # 480.status-ntpd > daily_status_ntpd_enable="NO" # Check NTP status > > Modified: head/etc/periodic/daily/480.leapfile-ntpd > ============================================================================== > --- head/etc/periodic/daily/480.leapfile-ntpd Tue Oct 17 01:12:17 2017 (r324680) > +++ head/etc/periodic/daily/480.leapfile-ntpd Tue Oct 17 01:15:13 2017 (r324681) > @@ -13,8 +13,15 @@ fi > > case "$daily_ntpd_leapfile_enable" in > [Yy][Ee][Ss]) > - anticongestion > - service ntpd onefetch > + case "$daily_ntpd_leapfile_background" in > + [Yy][Ee][Ss]) > + (anticongestion && service ntpd onefetch) & > + ;; > + *) > + anticongestion > + service ntpd onefetch > + ;; > + esac > ;; > esac > >