Date: Fri, 31 Mar 1995 00:04:05 -0800 From: "Jordan K. Hubbard" <jkh@freefall.cdrom.com> To: "Justin T. Gibbs" <gibbs@estienne.CS.Berkeley.EDU> Cc: Gennady Sorokopud <gena@netvision.net.il>, "Jordan K. Hubbard" <jkh@freebsd.org>, CVS-commiters@time.cdrom.com, cvs-sys@time.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa if_ep.c if_epreg.h Message-ID: <26591.796637045@freefall.cdrom.com> In-Reply-To: Your message of "Thu, 30 Mar 95 23:53:46 PST." <199503310753.XAA01697@estienne.cs.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> Oh, I'm not saying that they won't work, but in most cases, if there is someo ne > on the commit list that has the specific hardware to test a patch, it will be > tested before being comitted. The reason that only certain people have > commit priveledges is so that patches can be reviewed before being incorperat ed > into the tree. My question to Jordan was about how good a review he gave > the code before putting it in the tree. And to which (again, for Gennady's edification here) I replied that I essentially had done no more than syntax-check it, making sure it didn't break the tree (which is basically of the *minimum* expected degree of checking). I would say that the desired order of protocol (from most to least desirable) is: 1. Code check, compile-test, commit. 2. Compile-test, commit, ask for feedback [, commit ..] 3. Drop on floor. Forget it. We frequently exercise *all three* of these options in our daily roles as core team members, and we're being silly if any of us are presuming some other idyllic state of perfection. The real trick is knowing when and where to draw the line between these options. Sometimes we make the right judgement call and option #3 is fairly exercised to make time for something more important. Still more often, however, option 3 is exercised by default when everyone manages to think/hope that someone else is doing something. Since Justin hadn't called out "mine!" when this stuff started filtering in 4-5 days ago, I was starting to get the fear that the bit bucket was looming. Believing a #3 imminent, I exercised option #2. Had I known that Justin had a "#1" up his sleeve I wouldn't have done anything at all! :-) Jordan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26591.796637045>