From owner-freebsd-current@freebsd.org  Tue Jun 14 03:28:58 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9820EAF290F
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Tue, 14 Jun 2016 03:28:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 8806C2BF4;
 Tue, 14 Jun 2016 03:28:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id 817031CE3;
 Tue, 14 Jun 2016 03:28:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 34E4D21D02;
 Tue, 14 Jun 2016 03:28:58 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id WII9V49aXppZ; Tue, 14 Jun 2016 03:28:51 +0000 (UTC)
Subject: Re: 11.0 -r301815 to -r310873 using WITH_META_MODE=yes : an empty
 filename failure
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 92F5421CF4
To: "Simon J. Gerraty" <sjg@juniper.net>
References: <85435AE2-3F2C-4330-9751-729D99716A8C@dsl-only.net>
 <65e079c5-6b69-1b94-6bc8-ee32269cc98c@FreeBSD.org>
 <57295.1465874334@kaos.jnpr.net>
Cc: Mark Millard <markmi@dsl-only.net>,
 FreeBSD Current <freebsd-current@freebsd.org>
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <99ee7f26-573f-2aeb-c569-728602bb3593@FreeBSD.org>
Date: Mon, 13 Jun 2016 20:28:50 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <57295.1465874334@kaos.jnpr.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 03:28:58 -0000

On 6/13/16 8:18 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@freebsd.org> wrote:
>>>> ${_FIRM}: ${.CURDIR}/../../../../contrib/dev/drm2/radeonkmsfw/${_FIRM}.uu
>>>>         uudecode -p $? > ${.TARGET}
> 
> Targets like this that use $? or ${.OODATE} are a bad fit with META mode.
> 
> If the normal make rules think the target is up to date, .OODATE will be
> empty, thus if meta_oodate says the target is out-of-date, the script
> will run with no args - because $? expands to nothing.
> 
> So either the use of $? should be replaced with ${.ALLSRC} or something
> else that will be consistent, or the target should be marked .NOMETA
> 
> FYI we can [ab]use ${.OODATE} as a token to prevent a line of a script
> from being compared - meta mode knows that the value of .OODATE is
> inconsistent so should not be compared... thus putting
> ${.OODATE:MNO_META_CMP} on a line expands to nothing - no impact on the
> command but still tells meta_oodate to ignore that line for comparison
> purposes. 
> 

The problem is missing-meta requiring a .meta file here.  The $?/.OODATE
comparison exception is only used meta_oodate() if there is already a
.meta file, not for the new missing .meta logic.

-- 
Regards,
Bryan Drewery