From owner-svn-src-all@freebsd.org Mon Feb 4 16:51:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3610214D5157 for ; Mon, 4 Feb 2019 16:51:22 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AD78F8E3DF for ; Mon, 4 Feb 2019 16:51:21 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-ed1-x52d.google.com with SMTP id o10so404017edt.13 for ; Mon, 04 Feb 2019 08:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=OOuUnDf3sV4HXUipUZ4dYaU6gi6ZI49TFia3TefTgLw=; b=JSN48QOW4aT1kKIpYfTBmwf02c8rwa3fzPczXzHJVzor87PhjIxa7S0JVOSgG+yLk0 xh87zShFn62QZNINiggtGtX6npMCiOJ2LvyaQkIhNiJUUEaCAsE571qeBkqvdGUJC8Wy t0P/UyuwCb8mm2mRx2WRa7Y9rriNFz5kacU3tM28lDGd5uMZsIPfdtCMEUIYTfH1QAOj rCYFj3daVxd8stYtgtGrEC85RBHFwNw9qecXayW2l9/JJ0Ok2WVy9PsY24K1davimpYD f5VBn+7b6gjht/ESOKmeQpDH8wby3LeKvXVqhb3s8a/+iQR41OOezCFaYE98JRuCEeUx 823Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OOuUnDf3sV4HXUipUZ4dYaU6gi6ZI49TFia3TefTgLw=; b=r+aBDVV1euCysj1o0/rmFeDrkFywZiNQjf1GQqEgvyLsfpYYCDPls3+QCmvqpzpwv1 QuwO+Uh1s7eHsthJXtt+4JASHlKHXowRqILqOwjxDwJFUOXZL4DVHV1qA6ZLGt4bu0sH FINgqMMvFhEeyo9lYXbukh1n5nPl1POfctYkfCBhGAngqVgRPBWkCCksk8P7BjbaKPmw 5kZqR77LsutAlu6BLZPS6QWn4L+mSApZ6sO/A9UsL/fymXwSiIEkpfwoycLjTd7NdV38 fP54QyKBiHneLerBaiwp16Z99FWI+Yxo8zh+PjB3Z1+mIoP/pk+CP0z1erkgsD7ObzUn jEww== X-Gm-Message-State: AHQUAub3W0geb2JlAChUz+PTJ1MhzAHwEmT3sL0HEgvOo5C3Cqs25FIk pWJqguJAkZnYdHaj5ZFalU+8Aw== X-Google-Smtp-Source: AHgI3IZZqPoCZ1eciS9tmcJUfWUmIp/VK6dRbmp88wCJMCPIoG68TG6DAyqIkU4FC6XmT+cXigEBUg== X-Received: by 2002:a17:906:8249:: with SMTP id f9mr251754ejx.134.1549299080205; Mon, 04 Feb 2019 08:51:20 -0800 (PST) Received: from [10.44.128.75] ([161.12.40.153]) by smtp.gmail.com with ESMTPSA id l51sm4435903edb.36.2019.02.04.08.51.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 08:51:18 -0800 (PST) Subject: Re: svn commit: r343745 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201902041613.x14GDf4k022902@repo.freebsd.org> From: Steven Hartland Message-ID: Date: Mon, 4 Feb 2019 16:51:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <201902041613.x14GDf4k022902@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: AD78F8E3DF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 16:51:22 -0000 On 04/02/2019 16:13, Alexander Motin wrote: > Author: mav > Date: Mon Feb 4 16:13:41 2019 > New Revision: 343745 > URL: https://svnweb.freebsd.org/changeset/base/343745 > > Log: > Add missed tunables/sysctls for some new vdev variables. > > While there, make few existing sysctls writeable, since there is no reason > not to. > > MFC after: 1 week > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c Mon Feb 4 16:02:03 2019 (r343744) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c Mon Feb 4 16:13:41 2019 (r343745) > @@ -165,29 +165,38 @@ static vdev_ops_t *vdev_ops_table[] = { > > /* target number of metaslabs per top-level vdev */ > int vdev_max_ms_count = 200; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count, CTLFLAG_RWTUN, > &vdev_max_ms_count, 0, > - "Maximum number of metaslabs per top-level vdev"); > + "Target number of metaslabs per top-level vdev"); > > /* minimum number of metaslabs per top-level vdev */ > int vdev_min_ms_count = 16; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, min_ms_count, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, min_ms_count, CTLFLAG_RWTUN, > &vdev_min_ms_count, 0, > "Minimum number of metaslabs per top-level vdev"); > > /* practical upper limit of total metaslabs per top-level vdev */ > int vdev_ms_count_limit = 1ULL << 17; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count_limit, CTLFLAG_RWTUN, > + &vdev_ms_count_limit, 0, > + "Maximum number of metaslabs per top-level vdev"); > > /* lower limit for metaslab size (512M) */ > int vdev_default_ms_shift = 29; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, default_ms_shift, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, default_ms_shift, CTLFLAG_RWTUN, > &vdev_default_ms_shift, 0, > - "Shift between vdev size and number of metaslabs"); > + "Default shift between vdev size and number of metaslabs"); > > /* upper limit for metaslab size (256G) */ > int vdev_max_ms_shift = 38; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_shift, CTLFLAG_RWTUN, > + &vdev_max_ms_shift, 0, > + "Maximal shift between vdev size and number of metaslabs"); It's a just a nit but I believe this should Maximum, like the others, instead of Maximal. > > boolean_t vdev_validate_skip = B_FALSE; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, validate_skip, CTLFLAG_RWTUN, > + &vdev_validate_skip, 0, > + "Bypass vdev validation"); > > /* > * Since the DTL space map of a vdev is not expected to have a lot of >