From owner-svn-src-head@FreeBSD.ORG Wed May 18 11:21:34 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 906CF106564A; Wed, 18 May 2011 11:21:34 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe08.c2i.net [212.247.154.226]) by mx1.freebsd.org (Postfix) with ESMTP id 717658FC12; Wed, 18 May 2011 11:21:32 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=6QwXiDozn7Gnsf2tGidwH+ndAwLlGixx7JAIKZICKmI= c=1 sm=1 a=SvYTsOw2Z4kA:10 a=u5Tu-HhieqoA:10 a=dBRESv0yCI8A:10 a=N659UExz7-8A:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=6I5d2MoRAAAA:8 a=h0r91CyQN9zrCnRR5pQA:9 a=pILNOxqGKmIA:10 a=Jmo6dA6avm11kL81:21 a=bwF__ucf-cuQjGx2:21 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 128219579; Wed, 18 May 2011 13:21:31 +0200 Received-SPF: softfail receiver=mailfe08.swip.net; client-ip=188.126.198.129; envelope-from=hselasky@freebsd.org From: Hans Petter Selasky To: Andriy Gapon Date: Wed, 18 May 2011 13:20:24 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; ) References: <201105180740.p4I7eCVx066426@svn.freebsd.org> In-Reply-To: <201105180740.p4I7eCVx066426@svn.freebsd.org> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201105181320.24252.hselasky@freebsd.org> Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r222051 - in head/sys/dev: sound/usb usb usb/input usb/storage X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2011 11:21:34 -0000 On Wednesday 18 May 2011 09:40:12 Andriy Gapon wrote: > Author: avg > Date: Wed May 18 07:40:12 2011 > New Revision: 222051 > URL: http://svn.freebsd.org/changeset/base/222051 > > Log: > usb: change to one-pass probing of device drivers > > This brings USB bus more in line with how newbus is supposed to be used. > Also, because of the two-pass probing the following message was produced > by devd in default configuration when almost any USB device was > connected: > Unknown USB device: vendor <> product <> bus <> > This should be fixed now. > > Note that many USB device drivers pass some information from probe > method to attach method via ivars. For this to continue working we rely > on the fact that the subr_bus code calls probe method of a winning driver > again before calling its attach method in the case where multiple > drivers claim to support a device. This is done because device > description is set in successful probe methods and we want to get a > correct device description from a winning driver. So now this logic is > re-used for setting ivars too. > > Reviewed by: hselasky > MFC after: 1 month > > Modified: > head/sys/dev/sound/usb/uaudio.c > head/sys/dev/usb/input/uhid.c > head/sys/dev/usb/input/ukbd.c > head/sys/dev/usb/input/ums.c > head/sys/dev/usb/storage/umass.c > head/sys/dev/usb/storage/ustorage_fs.c > head/sys/dev/usb/usb_device.c > head/sys/dev/usb/usbdi.h > Looks like you missed ng_ubt.c. Just do a "grep -r" for the replaced fields. --HPS