Date: Sun, 20 Nov 2011 15:27:16 +0000 From: Chris Rees <crees@freebsd.org> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: Stanislav Sedov <stas@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: Makefile Issue Message-ID: <CADLo838=H5AQ4CZzfzs_2KqfgTR_MS%2Br6S3VSmem5NCYvnA=NA@mail.gmail.com> In-Reply-To: <201111201347.pAKDldYU003839@slippy.cwsent.com> References: <stas@FreeBSD.org> <20111120000304.343059f4.stas@FreeBSD.org> <201111201347.pAKDldYU003839@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 November 2011 13:47, Cy Schubert <Cy.Schubert@komquats.com> wrote: > In message <20111120000304.343059f4.stas@FreeBSD.org>, Stanislav Sedov > writes: >> On Fri, 18 Nov 2011 07:42:56 -0800 >> Cy Schubert <Cy.Schubert@komquats.com> mentioned: >> >> > Hi everyone, >> > >> > Can anyone enlighten me as to why this following make fragment doesn't >> > work? It falls through to .else. >> > >> > PKGNAMESUFFIX=3D =A0-devel >> > .if defined(PKGNAMESUFFIX) && !empty(PKGNAMESUFFIX) >> > MASTER_SITES=3D =A0 http://www.fwbuilder.org/nightly_builds/fwbuilder-= 5.0/build >> - >> > ${BUILD}/ >> > PORTVERSION=3D =A0 =A0${DISTVERSION}.b${BUILD} >> > .else >> > MASTER_SITES=3D =A0 SF/${PORTNAME}/Current_Packages/${PORTVERSION} >> > DISTVERSIONSUFFIX=3D =A0 =A0 =A0.${BUILD} >> > .endif >> > >> > If I replace PKGNAMESUFFIX=3D =A0-devel and the .if defined... with >> > PKGNAMESUFFIX=3D =A0"-devel" >> > .if defined(PKGNAMESUFFIX) && ${PKGNAMESUFFIX} =3D=3D "-devel" >> > it works. >> > >> >> Works here. >> >> Why do you think it doesn't work for you? > > Got it working a couple of days ago. Typo elsewhere in the makefile. Great to hear. I find that make -V can be your friend, but the thing that mostly trips me up here is doing a conditional based on LOCALBASE or similar before bsd.port.pre.mk. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838=H5AQ4CZzfzs_2KqfgTR_MS%2Br6S3VSmem5NCYvnA=NA>