Date: Tue, 16 Aug 2005 23:29:49 +0200 From: Kirill Ponomarew <krion@voodoo.oberon.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c src/sys/opencrypto xform.c Message-ID: <20050816212949.GG55949@voodoo.oberon.net> In-Reply-To: <200508161859.j7GIx0jU013523@repoman.freebsd.org> References: <200508161859.j7GIx0jU013523@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 16, 2005 at 06:59:00PM +0000, Pawel Jakub Dawidek wrote: > pjd 2005-08-16 18:59:00 UTC > > FreeBSD src repository > > Modified files: > sys/crypto/rijndael rijndael-alg-fst.c > sys/opencrypto xform.c > Log: > Check key size for rijndael, as invalid key size can lead to kernel panic. > It checked other algorithms against this bug and it seems they aren't > affected. > > Reported by: Mike Tancsa <mike@sentex.net> > PR: i386/84860 > Reviewed by: phk, cperciva(x2) I couldn't build it: cc -O2 -fno-strict-aliasing -pipe -I/usr/src/sbin/gbde/../../sys -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -c /usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c /usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c: In function `rijndaelKeySetupEnc': /usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c:737: warning: implicit declaration of function `KASSERT' /usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c:738: warning: left-hand operand of comma expression has no effect *** Error code 1 Stop in /usr/src/sbin/gbde. -Kirill
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050816212949.GG55949>