From owner-freebsd-gnome@FreeBSD.ORG  Tue Jun 29 17:17:52 2004
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: freebsd-gnome@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F40A416A4CE; Tue, 29 Jun 2004 17:17:51 +0000 (GMT)
Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de
	[212.202.50.15])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A124543D39; Tue, 29 Jun 2004 17:17:50 +0000 (GMT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from dhcp-11.local ([172.16.0.11] helo=localhost)
	by fillmore.dyndns.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34 (FreeBSD))
	id 1BfMEi-000P3m-G4; Tue, 29 Jun 2004 19:17:46 +0200
Date: Tue, 29 Jun 2004 19:17:57 +0200
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v482)
To: Hye-Shik Chang <perky@i18n.org>
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
In-Reply-To: <20040629170416.GA87430@i18n.org>
Message-Id: <4391E0B7-C9F0-11D8-9FE1-00039312D914@fillmore-labs.com>
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: Bob Melson <melsonr@earthlink.net>
cc: gnome@freebsd.org
cc: freebsd-ports@freebsd.org
cc: Michael Nottebrock <michaelnottebrock@gmx.net>
Subject: Re: A question about dependencies
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jun 2004 17:17:52 -0000

Hye-Shik Chang wrote:

> On Tue, Jun 29, 2004 at 06:54:44PM +0200, Michael Nottebrock wrote:
>> On Tuesday 29 June 2004 18:41, Hye-Shik Chang wrote:
>>
>>> Without runtime depencency, they will need some treatments to remove
>>> python site packages directory ($PREFIX/lib/python2.3/site-packages).
>>> I see that splitting python ports out from libxml2 and libxslt port
>>> would be better than that.
>>
>> Perhaps. However, it would still be nice to be able to USE_PYTHON in 
>> such a
>> slave port. Is there no way to add some shimmies to bsd.python.mk so a
>> buildtime only dependency becomes feasible?
>>
>
> Okay.  Please review this patch whether it's enough to resolve the
> problem.
>
> Index: Mk/bsd.python.mk
> ===================================================================
> RCS file: /home/pcvs/ports/Mk/bsd.python.mk,v
> retrieving revision 1.50
> diff -u -r1.50 bsd.python.mk
> --- Mk/bsd.python.mk	21 Jun 2004 01:33:52 -0000	1.50
> +++ Mk/bsd.python.mk	29 Jun 2004 17:01:35 -0000
> @@ -275,11 +275,17 @@
>  .endif
>
>  # dependencies
> -PYTHON_NO_DEPENDS?=		NO
> +PYTHON_NO_DEPENDS?=			NO
> +PYTHON_NO_BUILD_DEPENDS?=	NO
> +PYTHON_NO_RUN_DEPENDS?=		NO
>
>  .if ${PYTHON_NO_DEPENDS} == "NO"
> +.if ${PYTHON_NO_BUILD_DEPENDS} == "NO"
>  BUILD_DEPENDS+=	${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
> +.if ${PYTHON_NO_RUN_DEPENDS} == "NO"
>  RUN_DEPENDS+=	${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
>  .endif		# ${PYTHON_NO_DEPENDS} == "NO"
>
>  .if defined(USE_ZOPE)

I would like something more uniform, like USE_PYTHON_BUILD, 
USE_PYTHON_RUN checked with defined(). The above seems to be too 
sensitive to bugs like PYTHON_NO_DEPENDS=no, and it is not obvious what 
..._NO_... = "NO" means, contrary to ..._NO_... = "yes".

-Oliver