From owner-svn-src-head@freebsd.org  Tue Nov 14 15:58:06 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3AF0DD49A4;
 Tue, 14 Nov 2017 15:58:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8112B6368A;
 Tue, 14 Nov 2017 15:58:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 7986510A8BA;
 Tue, 14 Nov 2017 10:58:04 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r325793 - head/sys/dev/pci
Date: Tue, 14 Nov 2017 07:47:33 -0800
Message-ID: <1911777.0IZEGYVEAQ@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <201711140505.vAE555QF042553@repo.freebsd.org>
References: <201711140505.vAE555QF042553@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Tue, 14 Nov 2017 10:58:04 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 15:58:06 -0000

On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote:
> Author: imp
> Date: Tue Nov 14 05:05:05 2017
> New Revision: 325793
> URL: https://svnweb.freebsd.org/changeset/base/325793
> 
> Log:
>   Provide pcie_link_status and pcie_link_cap convenience functions.
>   
>   Sponsored by: Netflix

Note that we already have pcie_read_config() (documented in the manpage).
With pcie_read_config() these would be one liners:

pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2);

This is what the existing hotplug code uses rather than having dedicated
functions for each PCI-e register.

New functions should be documented in pci.9.

-- 
John Baldwin