From owner-svn-src-all@freebsd.org Tue Feb 2 09:58:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EBDFA98948; Tue, 2 Feb 2016 09:58:55 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 0A03D1FF5; Tue, 2 Feb 2016 09:58:54 +0000 (UTC) (envelope-from des@des.no) Received: from desk.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id DFEDCAE5E; Tue, 2 Feb 2016 09:58:53 +0000 (UTC) Received: by desk.des.no (Postfix, from userid 1001) id CF9C64655C; Tue, 2 Feb 2016 10:58:48 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294464 - in head: crypto/openssh crypto/openssh/contrib/redhat crypto/openssh/contrib/suse crypto/openssh/openbsd-compat crypto/openssh/regress crypto/openssh/regress/unittests crypto/... References: <201601202257.u0KMvA89056089@repo.freebsd.org> <56AFC036.6080508@FreeBSD.org> Date: Tue, 02 Feb 2016 10:58:48 +0100 In-Reply-To: <56AFC036.6080508@FreeBSD.org> (Bryan Drewery's message of "Mon, 1 Feb 2016 12:29:42 -0800") Message-ID: <86r3gvwi07.fsf@desk.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 09:58:55 -0000 Bryan Drewery writes: > Dag-Erling Sm=C3=B8rgrav wrote: > > -#PermitRootLogin no > > +#PermitRootLogin prohibit-password > Shouldn't the comments note the default? The default here is still > 'no'. Yes, I kept our local modification but somehow either didn't notice the comment or resolved the conflict incorrectly. > Upstream 7.1p2 does use PERMIT_NO_PASSWD rather than PERMIT_NO that we > have. I think we should make this change: We've always had this turned off, while upstream had it on by default. The new default doesn't work correctly with PAM, and the fix is not trivial. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no