Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Mar 2002 13:05:31 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Pierre Beyssac <beyssac@enst.fr>
Cc:        freebsd-current@freebsd.org
Subject:   RE: i386/boot2.c patches
Message-ID:  <XFMail.20020320130531.jhb@FreeBSD.org>
In-Reply-To: <20020320172647.A64459@bofh.enst.fr>

next in thread | previous in thread | raw e-mail | index | archive | help

On 20-Mar-2002 Pierre Beyssac wrote:
> Would anyone mind if I commit the following to i386/boot2.c?
> I've reviewed and tested them.
> 
> add -n option to boot2 to disallow user interruption
>       http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36016

Looks fine to me.

> boot2 cleanup (modulo style(9) and a minor typo in a comment):
>       http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36015

Looks mostly ok to me.  Not entirely sure about the autoboot changes
as it looks weird to load(kname) right before you change what kname
is.  I think the logic must somehow be wrong there.

Might want to ask Robert Nordier for review.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020320130531.jhb>