From owner-svn-src-all@freebsd.org Mon Dec 10 16:22:20 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDFD4132B8F7 for ; Mon, 10 Dec 2018 16:22:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1E85B809F0 for ; Mon, 10 Dec 2018 16:22:20 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1544458912; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=Ef72Y+R0NMmw3rU7+tzhUzWevclCqVTMV9361uwzO0axj7GTlq1EanWkZW0Z49tDIobTAxHpO0X3F TyzW1GnsXQplNfmpsby4V8tXC8tJMxpuLo2DtcvgxoA3tNK+l/M14mY4GtxFCLuAMrWGql3K9pHCT7 zl7HnjTGoUHEMwYvHn798HzEKvqiWKdoHqYPG/qkcswiTg6jXKuV++9DDTgv3WFJaZv0QmM43Z6K3y 0AWcbzUeGqqKg5tmz9I5xpAeyPb9YgtNefYp60A89EhcEeYvB2vag4F9EKxcMvDpszTUYwDtIS6ir9 u2To1ku+i7uFkwUd4jCDeK6j6QbRvxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Nw9cSnc0KrCcz0FEnKaEhgxuygnwHLASXVNbdRQDN5A=; b=dh9L9Jbo/bT79A8PbGbr0eFRF4n3BiGDQNSvJprhg1Y+uaclhvBl6hNXju8iJEkHW31PceO/Vr+fx kH2YHhCdOMV71sdMnruoCbTxSZeebkjqRUOfCiLcYDdY0zg5VDwgaTCh71qHDYQpGqyyu73SxaMyHF iJMuk+hJstKoglqTKKT+piBEFRptBHZSHmz9hVQTGuOF6w9iV4JRywi1H39T7EG/eWvSPwcu9GYYlp 8lWL53qqCO/ELDnNCaNytEoXfJiYK+gcA9yP889JBNrUTjyVIdNofFjUP6VLKEIkHJoNGfG+DGkQMk B/OOMt3FADEs35f1R+hwuJysBDAsfbg== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Nw9cSnc0KrCcz0FEnKaEhgxuygnwHLASXVNbdRQDN5A=; b=Qy5ROZPE3JQjHnAIUnOGnnKwBJXKJ4QyVI8nKCigINV6j+zo+4+ZqHtSen+O6GKhYCM7H6asOvQnj J6uMKZnxiF90pmLqawVrvYInEU1Zirfxdr/GYRsM0wMvGwrWMWiLg7GRKny5L1bwPvu13wx5Aji50R 0OYMd8+aJXl99Q65j+LbEZzYq5NNvmWdbnxNwyyNBo5dTFzE9p2gptBC0StHgtOS/ILEg17UtGyJyY B4xYUtGdAMWE0k+RBH7WyM6MuFK6WNbbKD8wcWCEFAAt2Uh+XzLVq3KWwdfXIO9rfc9yuMe8q/Ykl/ C63QDBU0/pyR2D4WzfHMVmeVumEUpuw== X-MHO-RoutePath: aGlwcGll X-MHO-User: b1f1ca5f-fc97-11e8-a59a-7b143e15dabc X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id b1f1ca5f-fc97-11e8-a59a-7b143e15dabc; Mon, 10 Dec 2018 16:21:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wBAGM95p072416; Mon, 10 Dec 2018 09:22:09 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1544458929.1860.329.camel@freebsd.org> Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... From: Ian Lepore To: Warner Losh , Cy Schubert Cc: "Rodney W. Grimes" , Oliver Pinter , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Cy Schubert Date: Mon, 10 Dec 2018 09:22:09 -0700 In-Reply-To: References: <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net> <201812100640.wBA6eaMA052004@slippy.cwsent.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1E85B809F0 X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 16:22:21 -0000 On Sun, 2018-12-09 at 23:47 -0700, Warner Losh wrote: > On Sun, Dec 9, 2018, 11:40 PM Cy Schubert wrote: > > > > > In message <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net>, > > "Rodney W. Gri > > mes" writes: > > > > > > > > > > > On Sun, Dec 9, 2018 at 2:03 PM Oliver Pinter < > > oliver.pinter@hardenedbsd.org > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Sunday, December 9, 2018, Warner Losh > > > > > wrote: > > > > > > > > > > > > > > > > > On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < > > > > > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In message <201812090645.wB96jnso066329@repo.freebsd.or > > > > > > > > g>, Cy > > > > > > Schubert > > > > > > > > > > > > > > > > > > > > > > > writes: > > > > > > > > > > > > > > > > > > Author: cy > > > > > > > > > Date: Sun Dec  9 06:45:49 2018 > > > > > > > > > New Revision: 341759 > > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > > > > > > > > > > > > > > > > > > Log: > > > > > > > > >   MFV r341618: > > > > > > > > > > > > > > > > > >   Update wpa 2.6 --> 2.7. > > > > > > > > Relnotes: yes > > > > > > > As an FYI, or maybe a new procedure, doing a reply to > > > > > > > a commit message adding relnotes: yes does very little > > > > > > > to insure that this commit gets refered to in release > > > > > > > notes. > > > > > > > > > > > > > > What about we add RELNOTES.missed to the tree > > > > > > > next to UPDATING, and when someone forgets to tag > > > > > > > the Relnotes:yes into a commit you just follow up > > > > > > > with a commit to that file, stating the svn revision > > > > > > > which was missing the note and then we have a nice > > > > > > > documented and clean way to extract the missing > > > > > > > release note items, rather than trying to cull it > > > > > > > from a thread in a mail list archive. > > > > > > > > > > > > > > The file would get truncated to 0 at appropriate > > > > > > > times on various branches. > > > > > > > > > > > > > How about just RELNOTES. You put the revision that is > > > > > > relevant and > > a qui > > > > > > ck > > > > > > > > > > > > > > > > > > > > > blurb. That way we don't have to look in two places. All > > > > > > release > > notes g > > > > > > o > > > > > > > > > > > > > > > > > > > > > in here, no exceptions. You can retroactively tag them, or > > > > > > you can > > commi > > > > > > t > > > > > > > > > > > > > > > > > > > > > this as part of commit. > > > My one concern is that if we remove the Relnotes: yes line > > > from the commits then we may end up totally ignoring the > > > need to put entries in RELNOTES, which unlike UPDATING > > > do not have consequences if ignored. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I don't really know SVN, but there wouldn't be a chicken egg > > > > > probem > > durin > > > > > > g > > > > > > > > > > > > > > commit time? I mean you would really know the SVN id. So you > > > > > could > > only a > > > > > > dd > > > > > > > > > > > > > > a specific revision in a different commit to RELEASE file. > > > > > > > > > Generally, you can guess really well, and fix it in the case of > > > > a lost > > race > > > > > > > > > > > easily. > > > No reason to guess, if you add the RELNOTES change with the > > > commit > > > then it is the revision that added the RELNOTES entry, so a log > > > view > > > of RELNOTES would show you the revision.  If you do it after > > > words > > > or edit an existing entry in the RELNOTES file that is also > > > fairly > > > clear as that commit has no other files touched. > > > > > > > > > > > > > > > You'd add the release notes text in full to the file, with a > > > > pointer > > to the > > > > > > > > > > > revision(s) for the feature. > > > If you modify RELNOTES with the commit adding the feature we > > > could easily use a pointer of "this commit", the svn version > > > number > > > of that added entry is self referencing to the actual change, > > > which I actually rather like the idea of. > > > > > > > > > > > > > > > Warner > > > > > > > > > > > > > > > > > > > > > > > > > > Have a blurb at the top that tells people what > > > > > > order to add them in, and you'd be set. We'd then retire > > > > > > "relnotes: > > yes" > > > > > > > > > > > > > > > > > > > > > > > > in > > > > > > the commit message. This would also allow 'helpers' to > > > > > > format the > > RELNOT > > > > > > ES > > > > > > > > > > > > > > > > > > > > > file as we go rather than having to play 2 years of catch- > > > > > > up at > > major > > > > > > > > > > > > > > > > > > > > > > > > branch times. > > > Yes.  You could actually "delete" an entry from RELNOTES once a > > > proper entry in the actual release notes had been created, such > > > that RELNOTES is really a list of pending items. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Having it in the commit message just doesn't work, and this > > > > > > is one > > of ma > > > > > > ny > > > > > > > > > > > > > > > > > > > > > reasons: Cy forgot. Other times I'll do something and it's > > > > > > only a > > month > > > > > > > > > > > > > > > > > > > > > > > > later I realize it needs to be in the release notes after > > > > > > some > > issue has > > > > > > > > > > > > > > > > > > > > > > > > come up.... Other times I put relnotes: yes in only to > > > > > > realize > > that's my > > > > > > > > > > > > > > > > > > > > > > > > vanity talking, and nobody else cares. > > > I agree, what we have now works poorly. > > Forgetting, yes, but also a hmmm moment. > > > > Initially my thinking was a file in doc/. Or maybe something like > > the > > vuxml port where we fill in the blanks and make validate to make > > sure > > all the i's are dotted and t's crossed. It's a little extra work > > for > > committers but would help re@ immensely, and get the details in > > from > > the get-go. > > > > My thought was a low friction,  proximate way to do a ticker of important > changes. Doc repo is too hard. Too much friction. A simple extra file puts > it all in one, easy to find and edit place... it can cause other things to > happen, further away. But it needs to be close by. > I agree that a RELNOTES file as plain ascii text will be the easiest thing for src committers to work with, and being easy will definitely improve the odds of being updated. We have empirical data on src committers updating an xml file in the docs repo, based on documenting version number bumps, and it all too often doesn't happen, I think laregely because it's a big hassle and it's out of sight in another repo. -- Ian