From owner-cvs-all  Tue Jan 19 15:31:03 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id PAA24830
          for cvs-all-outgoing; Tue, 19 Jan 1999 15:31:03 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from ceia.nordier.com (c2-52-dbn.dial-up.net [196.34.155.180])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA24819;
          Tue, 19 Jan 1999 15:30:49 -0800 (PST)
          (envelope-from rnordier@nordier.com)
Received: (from rnordier@localhost) by ceia.nordier.com (8.8.7/8.6.12) id BAA21245; Wed, 20 Jan 1999 01:30:17 +0200 (SAT)
From: Robert Nordier <rnordier@nordier.com>
Message-Id: <199901192330.BAA21245@ceia.nordier.com>
Subject: Re: -Werror
In-Reply-To: <19990119232309.B52012@bitbox.follo.net> from Eivind Eklund at "Jan 19, 99 11:23:10 pm"
To: eivind@FreeBSD.ORG (Eivind Eklund)
Date: Wed, 20 Jan 1999 01:30:15 +0200 (SAT)
Cc: rnordier@nordier.com, bde@zeta.org.au, cvs-committers@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by hub.freebsd.org id PAB24824
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Eivind Eklund wrote:
> On Tue, Jan 19, 1999 at 11:34:04PM +0200, Robert Nordier wrote:
> > Bruce Evans wrote:
> > 
> > > People are already committing code that should be caught by -Werror:
> > > 
> > > ../../netinet/if_ether.c: In function `arpresolve':
../../netinet/if_ether.c:330: warning: `la' might be used uninitialized in this function
> > > `la' _is_ used uninitialized in this function.
> > 
> > Last I heard, folks intent on establishing -Werror as a default
> > option were being threatened with mayhem or worse.
> > 
> > Is the point that we are nevertheless required to act "as if", at
> > least as far as new code is concerned?
> 
> I'm planning on keeping compiling at least one of my trees with
> -Werror.  This mean that the warnings will be fixed at _some_ level -
> either only locally in my tree, or globally if reasonable.  I'm also
> thinking of whether an automated notifier would be useful (with Cc: to
> jkh, of course, as it was jkh that vetoed adding it to bsd.kern.mk ;-)

Nice touch. :)

I've a number of static checkers here myself that I use fairly
regularly; so I'm not necessarily set against the idea of enforcing
-Werror.  These stylistic issues do tend to be divisive, though,
so it seemed worth checking whether some final policy decision had
been reached.

--
Robert Nordier

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message