Date: Tue, 25 Apr 2006 11:06:49 -0400 From: John Baldwin <jhb@freebsd.org> To: John Birrell <jb@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 96028 for review Message-ID: <200604251106.50641.jhb@freebsd.org> In-Reply-To: <200604242332.k3ONWeRq008991@repoman.freebsd.org> References: <200604242332.k3ONWeRq008991@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 24 April 2006 19:32, John Birrell wrote: > http://perforce.freebsd.org/chv.cgi?CH=96028 > > Change 96028 by jb@jb_freebsd2 on 2006/04/24 23:32:39 > > The latest hacks. > > Affected files ... > > .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_hacks.h#7 edit > > Differences ... > > ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_hacks.h#7 (text+ko) ==== > > @@ -18,12 +18,20 @@ > void vmem_free(vmem_t *, void *, size_t); > void vmem_destroy(vmem_t *); > > +#undef curthread > +#define curthread ((struct thread *) PCPU_GET(curthread))\ This is odd, why did you do this? Note that the cast shouldn't be needed for one, and that curthread is already basically defined to be this (though tweaked to optimize the kernel build for some archs like i386 and amd64). -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604251106.50641.jhb>