From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 8 11:20:19 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCEB516A41F for ; Mon, 8 Aug 2005 11:20:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54A2143D48 for ; Mon, 8 Aug 2005 11:20:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j78BKJbG014004 for ; Mon, 8 Aug 2005 11:20:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j78BKJd0014003; Mon, 8 Aug 2005 11:20:19 GMT (envelope-from gnats) Resent-Date: Mon, 8 Aug 2005 11:20:19 GMT Resent-Message-Id: <200508081120.j78BKJd0014003@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Daan Vreeken [PA4DAN]" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D513916A41F for ; Mon, 8 Aug 2005 11:16:44 +0000 (GMT) (envelope-from pa4dan@Vitsch.net) Received: from amsfep14-int.chello.nl (amsfep14-int.chello.nl [213.46.243.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 021B343D46 for ; Mon, 8 Aug 2005 11:16:43 +0000 (GMT) (envelope-from pa4dan@Vitsch.net) Received: from Vitsch.net ([62.195.249.78]) by amsfep14-int.chello.nl (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20050808111641.SIET28432.amsfep14-int.chello.nl@Vitsch.net> for ; Mon, 8 Aug 2005 13:16:41 +0200 Received: (from pa4dan@localhost) by Vitsch.net (8.12.3p2/8.11.3) id j78BFhmY048923; Mon, 8 Aug 2005 13:15:43 +0200 (CEST) (envelope-from pa4dan) Message-Id: <200508081115.j78BFhmY048923@Vitsch.net> Date: Mon, 8 Aug 2005 13:15:43 +0200 (CEST) From: "Daan Vreeken [PA4DAN]" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/84664: gctl_free() isn't called in fdisk.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Daan Vreeken \[PA4DAN\]" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2005 11:20:20 -0000 >Number: 84664 >Category: bin >Synopsis: gctl_free() isn't called in fdisk.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 08 11:20:18 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Daan Vreeken [PA4DAN] >Release: FreeBSD 5.4-RELEASE i386 >Organization: Vitsch Electronics >Environment: System: FreeBSD Racebeest.Vitsch.LAN 5.4-RELEASE FreeBSD 5.4-RELEASE #5: Sun Aug 7 19:58:10 CEST 2005 root@Racebeest.Vitsch.LAN:/usr/src/sys/i386/compile/Laptop i386 >Description: In the current version of fdisk.c gctl_get_handle() and gctl_issue() are called in order to update the MBR of a disk without a corresponding call to gctl_free(). >How-To-Repeat: n/a >Fix: Apply the following patch to src/sbin/fdisk/fdisk.c : --- fdisk.c.patch begins here --- --- src/sbin/fdisk/fdisk.c.1_80 Mon Aug 8 13:05:02 2005 +++ src/sbin/fdisk/fdisk.c Mon Aug 8 13:06:09 2005 @@ -761,6 +761,7 @@ gctl_ro_param(grq, "geom", -1, q); gctl_ro_param(grq, "data", secsize, buf); q = gctl_issue(grq); + gctl_free(grq); if (q == NULL) return(0); warnx("%s", q); --- fdisk.c.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: