Date: Mon, 18 Jul 2005 17:50:18 GMT From: Brooks Davis <brooks@one-eyed-alien.net> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/83622: [ patch ] add network interfaces labeling support Message-ID: <200507181750.j6IHoIQA056413@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/83622; it has been noted by GNATS. From: Brooks Davis <brooks@one-eyed-alien.net> To: Roman Bogorodskiy <novel@freebsd.org> Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/83622: [ patch ] add network interfaces labeling support Date: Mon, 18 Jul 2005 10:40:53 -0700 This seems like an intresting and useful feature. I'd like to see the storage malloc'd instead of stuffed in the ifnet. There's no sense in using 64 bytes in ever ifnet when I suspect most people won't ever use this feature. It would also avoid hardcoding a limit in ifconfig (you'll want to restrict overall size, probably to MAX_PHYS). To maintain ABI compatability, the ifnet entry should be placed at the end of struct ifnet. That's required for RELENG_6 and I'd like to keep HEAD ABI compatable with RELENG_6 at least until 6.0-RELEASE. On the nikpick front, strlen returns a length, not a boolen. Any reason for skipping to 128 and 129 in the ioctls? Updates to the ifconfig(8) and ifnet(9) manpages will also be needed before a commit can happen. Thanks for your submission. -- Brooks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507181750.j6IHoIQA056413>