Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 May 2008 14:59:28 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Alfred Perlstein <alfred@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c
Message-ID:  <200805051459.29200.jhb@freebsd.org>
In-Reply-To: <20080505184003.GL32532@elvis.mu.org>
References:  <200805051603.m45G3rrN089219@repoman.freebsd.org> <20080505184003.GL32532@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 05 May 2008 02:40:03 pm Alfred Perlstein wrote:
> I'm _not_ objecting, just interested in why.
> 
> Any references to discussions on this?  Are we now safe for
> future compat or something?

Having FILE be opaque broke just about every 'configure' script on the 
planet. :(

> * John Baldwin <jhb@FreeBSD.org> [080505 09:04] wrote:
> > jhb         2008-05-05 16:03:52 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     include              stdio.h 
> >     lib/libc/stdio       clrerr.c feof.c ferror.c fileno.c getc.c 
> >                          getchar.c local.h putc.c putchar.c 
> >                          xprintf.c 
> >   Log:
> >   Expose FILE's internals to the world again in all their glory.  Restore
> >   all the previous inline optimizations as well.  FILE is back to using
> >   __mbstate_t, struct pthread *, and struct pthread_mutex *.
> >   
> >   Revision  Changes    Path
> >   1.70      +172 -4    src/include/stdio.h
> >   1.12      +2 -2      src/lib/libc/stdio/clrerr.c
> >   1.12      +2 -2      src/lib/libc/stdio/feof.c
> >   1.12      +3 -1      src/lib/libc/stdio/ferror.c
> >   1.13      +2 -2      src/lib/libc/stdio/fileno.c
> >   1.16      +3 -0      src/lib/libc/stdio/getc.c
> >   1.15      +3 -0      src/lib/libc/stdio/getchar.c
> >   1.33      +2 -132    src/lib/libc/stdio/local.h
> >   1.16      +3 -0      src/lib/libc/stdio/putc.c
> >   1.16      +3 -0      src/lib/libc/stdio/putchar.c
> >   1.8       +0 -1      src/lib/libc/stdio/xprintf.c
> 
> -- 
> - Alfred Perlstein
> 



-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805051459.29200.jhb>