From owner-freebsd-standards  Sat Feb 16 18: 2:22 2002
Delivered-To: freebsd-standards@freebsd.org
Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153])
	by hub.freebsd.org (Postfix) with ESMTP
	id E895C37B405; Sat, 16 Feb 2002 18:02:18 -0800 (PST)
Received: from madman.nectar.cc (madman.nectar.cc [10.0.1.111])
	by gw.nectar.cc (Postfix) with ESMTP
	id 72DA836; Sat, 16 Feb 2002 20:02:18 -0600 (CST)
Received: (from nectar@localhost)
	by madman.nectar.cc (8.11.6/8.11.6) id g1H22Ig46992;
	Sat, 16 Feb 2002 20:02:18 -0600 (CST)
	(envelope-from nectar)
Date: Sat, 16 Feb 2002 20:02:18 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.ORG>
To: Mike Barcroft <mike@FreeBSD.ORG>
Cc: Chuck Rouillard <chuckr@opus.sandiegoca.ncr.com>,
	FreeBSD-Standards <freebsd-standards@FreeBSD.ORG>
Subject: Re: pathchk - review
Message-ID: <20020217020217.GB46829@madman.nectar.cc>
Mail-Followup-To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	Mike Barcroft <mike@FreeBSD.ORG>,
	Chuck Rouillard <chuckr@opus.sandiegoca.ncr.com>,
	FreeBSD-Standards <freebsd-standards@FreeBSD.ORG>
References: <20020129210829.GC50337@madman.nectar.cc> <20020205232519.N7805-101000@opus.sandiegoca.ncr.com> <20020212170303.B55750@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020212170303.B55750@espresso.q9media.com>
User-Agent: Mutt/1.3.27i
X-Url: http://www.nectar.cc/
Sender: owner-freebsd-standards@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-standards.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-standards>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-standards>
X-Loop: FreeBSD.ORG

On Tue, Feb 12, 2002 at 05:03:03PM -0500, Mike Barcroft wrote:
> > const char *illegalchar = "pathchk: Illegal character";
> > const char *memoryerror = "pathchk: No memory to allocate";
> > const char *nametoolong = "pathchk: Path component too long";
> > const char *pathchkhelp = "usage: pathchk [-p] path ...\n";
> > const char *pathtoolong = "pathchk: Pathname too long";
> > const char *posix_chars = "0123456789._-"
> > 			"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
> > 			"abcdefghijklmnopqrstuvwxyz";
> 
> These should all be #define's, 


Why?

> unless I missed somewhere that they are
> changed.

They are const :-)

Cheers,
-- 
Jacques A. Vidrine <n@nectar.cc>                 http://www.nectar.cc/
NTT/Verio SME          .     FreeBSD UNIX     .       Heimdal Kerberos
jvidrine@verio.net     .  nectar@FreeBSD.org  .          nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message