Date: Sun, 21 Aug 2005 23:35:54 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_misc.c Message-ID: <20050821213553.GC1037@garage.freebsd.pl> In-Reply-To: <bb4a86c705082114253fda9ee2@mail.gmail.com> References: <200508211916.j7LJGR72062875@repoman.freebsd.org> <bb4a86c705082113341d46203a@mail.gmail.com> <20050821205152.GB1037@garage.freebsd.pl> <bb4a86c705082114253fda9ee2@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 21, 2005 at 02:25:00PM -0700, Maksim Yevmenkin wrote: +> > +> in the future, i would really appreciate if you submit your patches +> > +> for review before committing them. +> >=20 +> > Sure, sorry about that. I assumed noone is interested, because noone +> > offered help to submitter. +>=20 +> actually, i was looking into this. unfortunately my emails did not +> make it to the list because someone broke our local mail system here. +> one of the smtp hosts we use does not have dns entry and my mail is +> rejected :( also i was very busy with real work for the last two +> weeks, so i did not have any spare time to look into this. +>=20 +> please take no offence, but i'd like to be involved when bluetooth +> code is changed. while i appreciate your work here, i'd like to see a +> slightly different patch. in particular, i do think think that +> ng_l2cap_free_con() should call ng_l2cap_xxx_untimeout() routines.=20 +> imo, ng_l2cap_free_con() should panic if it detects that callout is +> pending. also L2CAP_CON_AUTO_DISCON_TIMO and NG_L2CAP_CON_LP_TIMO are +> mutually exclusive. both use the same callout handle, so you can not +> have both at the same time. I saw it uses the same callout handle, but it also can cope when I call it twice. And in this case those two flags were set, so if they are mutually exclusive, something is wrong here and you may want to verify this as well. +> having said all that, i think your patch should stay for now. please +> do not MFC it just yet. i will look into this first thing tomorrow +> (monday). Ok, fell free to commit a better fix. I'm glad you can work on this, as you know the code best. Thanks. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDCPO5ForvXbEpPzQRAt24AKCJMWSJnvc4El2ve6OitSkJtUgDowCffHkY Fs1JqE2SXP+tAQZ8oLwXi2c= =GMOu -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050821213553.GC1037>