From owner-cvs-ports@FreeBSD.ORG  Mon Mar 22 13:57:04 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2583316A4CE; Mon, 22 Mar 2004 13:57:04 -0800 (PST)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i2MLv3bs059278;
	Mon, 22 Mar 2004 16:57:03 -0500 (EST)
	(envelope-from green@green.homeunix.org)
Received: from localhost (green@localhost)i2MLv2BO059275;
	Mon, 22 Mar 2004 16:57:03 -0500 (EST)
	(envelope-from green@green.homeunix.org)
Message-Id: <200403222157.i2MLv2BO059275@green.homeunix.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: Message from Kris Kennaway <kris@obsecurity.org> 
	<20040322210858.GA19409@xor.obsecurity.org> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 22 Mar 2004 16:57:02 -0500
Sender: green@green.homeunix.org
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio/xmms-imms Makefile distinfo
	ports/audio/xmms-imms/files patch-vars.mk.in 
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2004 21:57:04 -0000

Kris Kennaway <kris@obsecurity.org> wrote:
> On Mon, Mar 22, 2004 at 08:16:48AM -0800, Brian Feldman wrote:
> 
> > |  -CFLAGS = `xmms-config --cflags` @DEBUG_CFLAGS@ -Wall -fPIC -D_REENTRANT
> > |  +CFLAGS = `xmms-config --cflags` @DEBUG_CFLAGS@ @CFLAGS@ -Wall -fPIC -D_REENTRANT
> > | - CPPFLAGS = ${CFLAGS} -pedantic -fno-rtti
> > | + CXXFLAGS = ${CFLAGS} -pedantic -fno-rtti
> > |  -LDFLAGS = `xmms-config --libs` @LIBS@
> > |  +LDFLAGS = `xmms-config --libs` -lc @LIBS@
> 
> You didn't add this just now, but do you really need to link
> explicitly against -lc?  That seems odd.

I had odd toolchain errors (at least on -STABLE) without it.  You would 
think that missing symbols shouldn't be resolved at link time for a shared 
library, but that's what it was attempting to do without the benefit of the 
symbols found in libc.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\