From owner-freebsd-current@freebsd.org Sat Dec 22 20:27:30 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 702BC133A32E for ; Sat, 22 Dec 2018 20:27:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C044D6FBFF for ; Sat, 22 Dec 2018 20:27:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7E313133A32D; Sat, 22 Dec 2018 20:27:29 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58F8F133A32C for ; Sat, 22 Dec 2018 20:27:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 42A276FBFC; Sat, 22 Dec 2018 20:27:28 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id anrhghqye82YcanrigpVUm; Sat, 22 Dec 2018 13:27:20 -0700 X-Authority-Analysis: v=2.3 cv=NNSrBHyg c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=2ur7OfE09M0A:10 a=L0TlzgiqAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=7Qk2ozbKAAAA:8 a=VxmjJ2MpAAAA:8 a=eh1Yez-EAAAA:8 a=Xe7PpyctmunpBpIkOdIA:9 a=CjuIK1q_8ugA:10 a=-RtknO9RM1QA:10 a=h1pxpgV1WlEA:10 a=IAVDLmJhbIOVeWgv0OxI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=1lyxoWkJIXJV6VJUPhuM:22 a=7gXAzLPJhVmCkEl4_tsf:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id AEB272E2; Sat, 22 Dec 2018 12:27:16 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id wBMKRGY8050856; Sat, 22 Dec 2018 12:27:16 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id wBMKRGWJ050853; Sat, 22 Dec 2018 12:27:16 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201812222027.wBMKRGWJ050853@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Yuri Pankov cc: Cy Schubert , Mark Peek , Enji Cooper , Warner Losh , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , freebsd-current Subject: Re: workaround for VMware WS NAT bug triggered by OpenSSH 7.8p1 changes In-Reply-To: Message from Yuri Pankov of "Sat, 22 Dec 2018 23:13:49 +0300." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 22 Dec 2018 12:27:16 -0800 X-CMAE-Envelope: MS4wfNsy9Ihz3qfvbL4KuZKGwp1dcDh9gBngW8m01E7liMOZMYO2WUNtHMBE13G8ix985WJSwxVwcBsfmj0gUNPINpDC8QWHQ1v6vFtVkXDYCAILJ3W7MTmx AaA0SuHPYKBYXMKmHlzXiVzfOW9yvE5PUQgcvT9mkt39tNatj3OFL4a1vCm6p7f4ZcvhghcE3edEPdvi1xsK00JJOLbBo35RLrvP2xU+nmPMvOy9G+/SgGzO tu5ElgsgsvLJkx8/tqPC0/89Nz3Jpa9wupQpB75P766B3NqoOdQC1bRNG/RiXTMM0k2FmTDY/2/NVovll4/QJg== X-Rspamd-Queue-Id: 42A276FBFC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.26 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.62)[ip: (-3.50), ipnet: 64.59.128.0/20(-2.49), asn: 6327(-1.99), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[139.136.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 20:27:30 -0000 In message , Yuri Pankov write s: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --NAG3HGfiwhsHyGq3aNdsIv1NzTEMODbUH > Content-Type: multipart/mixed; boundary="c7yUHUJpZYpJqOrOWLAb4sE3Rmh2alrdi"; > protected-headers="v1" > From: Yuri Pankov > To: Cy Schubert > Cc: Mark Peek , Enji Cooper , > Warner Losh , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= > , freebsd-current > Message-ID: > Subject: Re: workaround for VMware WS NAT bug triggered by OpenSSH 7.8p1 > changes > References: <201812222009.wBMK9H5T050103@slippy.cwsent.com> > In-Reply-To: <201812222009.wBMK9H5T050103@slippy.cwsent.com> > > --c7yUHUJpZYpJqOrOWLAb4sE3Rmh2alrdi > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Cy Schubert wrote: > > In message <913730b6-c6f0-60b8-a589-e89e872b7f42@yuripv.net>, Yuri=20 > > Pankov write > > s: > >> Yuri Pankov wrote: > >>> In-Reply-To: > > l.gmail. > >>> com> > >>> Mark Peek wrote: > >>>> On Fri, Dec 21, 2018 at 9:30 PM Enji Cooper > > wro=3D > >>> te: > >>>> =3D20 > >>>>> > >>>>>> On Dec 21, 2018, at 17:48, Yuri Pankov wrote: > >>>>>> > >>>>>> Mark Peek wrote: > >>>>>>> Thanks for the cc:. I forwarded the original report on to an=20 > > interna=3D > >>> l > >>>>>>> VMware desktop product contact. > >>>>>> > >>>>>> Thank you. > >>>>>> > >>>>>>> What version of Workstation or Fusion is this occurring on? I=20 > > saw > >>>>>>> Workstation 14 mentioned but curious if it occurs on=20 > > Workstation 15 > >>>>>>> (latest). > >>>>>> > >>>>>> Running the latest available for download: 15.0.2 build-10952284. > >>>>> > >>>>> This is affecting me on VMware Fusion 11.0.1-11.0.2. I know it=20 > > wasn=3DE2=3D > >>> =3D80=3D99t > >>>>> affecting me on 10.x. I didn=3DE2=3D80=3D99t install 11.0.0, so I=20 > > don=3DE2=3D80=3D99=3D > >>> t know if it > >>>>> affects that version... > >>>>> > >>>>> Thanks so much! > >>>>> > >>>>> -Enji > >>>> =3D20 > >>>> =3D20 > >>>> BTW, there appears to be a workaround here using -o=20 > > 'IPQoS=3D3Dthroughput=3D > >>> ' > >>>> (untested by me). I've seen the issue forwarded internally but no=20 > > furth=3D > >>> er > >>>> discussions yet. > >>>> =3D20 > >>>> https://communities.vmware.com/thread/590825 > >> > >> Yes, that's exactly what the patch attached to original message does i= > f > >> we are running as a VMware guest. The workaround is known and it work= > s, > >> but it's not immediately clear and I just wanted it to be the default > >> for the time being. > >=20 > > The patch assumes VMWARE_GUEST_WORKAROUND unconditionally. Is this=20 > > intended? > > It's the added code that is ifdef'ed VMWARE_GUEST_WORKAROUND, so it can > be ripped out easily when no longer needed, and yes, it's enabled > unconditionally for now. And the check itself is if 'kern.vm_guest' > reports 'vmware'. It doesn't look that conditional to me. diff --git a/secure/usr.bin/ssh/Makefile b/secure/usr.bin/ssh/Makefile index 614cc7627fc5..023fa4a55be9 100644 --- a/secure/usr.bin/ssh/Makefile +++ b/secure/usr.bin/ssh/Makefile @@ -37,6 +37,9 @@ LIBADD+= crypto CFLAGS+= -DXAUTH_PATH=\"${LOCALBASE}/bin/xauth\" .endif +# Workaround VMware Workstation NAT bug +CFLAGS+=-DVMWARE_GUEST_WORKAROUND + .include .PATH: ${SSHDIR} -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.