Date: Wed, 19 Apr 2017 09:24:18 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r317145 - in stable/11/sys: boot/mips/uboot conf Message-ID: <201704191624.v3JGOImX031395@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201704191533.v3JFXOHk065533@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > Author: emaste > Date: Wed Apr 19 15:33:24 2017 > New Revision: 317145 > URL: https://svnweb.freebsd.org/changeset/base/317145 > > Log: > MFC r303442, r305343: remove CONSTRUCTORS from linker scripts > > r303442: remove CONSTRUCTORS from kernel linker scripts > > r305343: remove CONSTRUCTORS from MIPS uboot linker script > > The linker script CONSTRUCTORS keyword is only meaningful "when linking > object file formats which do not support arbitrary sections, such as > ECOFF and XCOFF"[1] and is ignored for other object file formats. > > LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove > CONSTRUCTORS from the linker script as it has no effect. > > [1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html ^^^^^^^^^^^^ links to external data is probably not a good idea in commit messages as it tends to disappear in time. There are some notable exceptions, ie *.freebsd.org:// is normally safe, but does get broken (there are reference to phab.freebsd.org that is now review.freebsd.org. Thoug most commiters might know this someone external reading svn logs would not.) netbsd.org, openbsd.org, etc are propably next safer, but nothing says one of those can not go poof some day. Same of Illumos.org which we frequently reference. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704191624.v3JGOImX031395>