From owner-cvs-all@FreeBSD.ORG Mon Jan 16 08:44:40 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90F9316A48B; Mon, 16 Jan 2006 08:44:40 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD8C143D45; Mon, 16 Jan 2006 08:44:39 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k0G8iP9W019921; Mon, 16 Jan 2006 10:44:25 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ip.net.ua [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 48164-02-5; Mon, 16 Jan 2006 10:44:15 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k0G8dRoe019730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 16 Jan 2006 10:39:28 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id k0G8dR8A077448; Mon, 16 Jan 2006 10:39:27 +0200 (EET) (envelope-from ru) Date: Mon, 16 Jan 2006 10:39:22 +0200 From: Ruslan Ermilov To: Scott Long Message-ID: <20060116083922.GD81316@ip.net.ua> References: <200601140812.k0E8CQPI036267@repoman.freebsd.org> <20060116041146.GA23438@dragon.NUXI.org> <20060115.231029.62233420.imp@bsdimp.com> <43CB42A9.8090601@samsco.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d01dLTUuW90fS44H" Content-Disposition: inline In-Reply-To: <43CB42A9.8090601@samsco.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: src-committers@FreeBSD.org, flz@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org, "M. Warner Losh" Subject: Re: cvs commit: src/usr.sbin/config main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2006 08:44:41 -0000 --d01dLTUuW90fS44H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 15, 2006 at 11:52:25PM -0700, Scott Long wrote: > M. Warner Losh wrote: >=20 > >In message: <20060116041146.GA23438@dragon.NUXI.org> > > "David O'Brien" writes: > >: On Sat, Jan 14, 2006 at 08:12:25AM +0000, Florent Thoumie wrote: > >: > Modified files: > >: > usr.sbin/config main.c=20 > >: > Log: > >: > - Change the exit message from "make cleandepend; make depend" to > >: > "make cleandepend && make depend". > >:=20 > >: I still think we should go back to the traditional: > >: "Don't forget to do ``make depend''\n" > >:=20 > >: The 'make cleandepend' step was to work around brokeness in 'make=20 > >depend'. > >: If 'make depend' is still so broken that one must do 'make cleandepend' > >: first, then 'make depend' should just blow away all the .depend files > >: first. > > > >Sadly, that won't work. > > > >Warner >=20 > Not that I don't believe you, but can you explain why it won't work?=20 > What happened that caused 10+ years of 'working' to turn to 'not working'? >=20 Several reasons: - Before we were always regenerating the kernel .depend file, even if nothing has changed. This was contrary to other .depend files that are only regenerated if some of the sources or their known dependencies have changed. The config/main.c commit log said this on the subject: : Ask that "make cleandepend" be run before "make depend", now that : we don't do this automatically. - "make cleandepend" wasn't to work around brokenness in "make depend". Instead, it's to make things work when make(1) cannot figure out by itself that it should regenerate .depend, e.g. when supporting .mk files change (kern.{pre,post}.mk, Makefile., Makefile built by config(8), etc.). In short, not runnign "make cleandepend" is equivalent to building world with -DNO_CLEAN, which is often possible but not guaranteed to work, and for the same set of reasons. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --d01dLTUuW90fS44H Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDy1u6qRfpzJluFF4RAh1BAKCVc72Af2TmK+nYZq6laUDdXyf1xgCdHNjO 5DBs+RmFifFpxBBm8AZuwwY= =9yvR -----END PGP SIGNATURE----- --d01dLTUuW90fS44H--