From owner-cvs-src@FreeBSD.ORG Fri Nov 16 01:35:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D8AE16A417; Fri, 16 Nov 2007 01:35:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D13CB13C457; Fri, 16 Nov 2007 01:35:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lAG1XgCJ005322; Thu, 15 Nov 2007 18:33:42 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 15 Nov 2007 18:33:12 -0700 (MST) Message-Id: <20071115.183312.619299480.imp@bsdimp.com> To: rwatson@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20071115194710.L82897@fledge.watson.org> References: <20071115181401.GA17094@troutmask.apl.washington.edu> <473C901F.1080906@elischer.org> <20071115194710.L82897@fledge.watson.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, glebius@FreeBSD.org, julian@elischer.org, sgk@troutmask.apl.washington.edu Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2007 01:35:02 -0000 In message: <20071115194710.L82897@fledge.watson.org> Robert Watson writes: : : On Thu, 15 Nov 2007, Julian Elischer wrote: : : >>> "no matter how small the change, use diff + patch to move it across." : >> : >> After applying the patch on your commit machine, is it too difficult to : >> actually retest before committing? This would catch the broken commit : >> before it becomes a Tinderbox issue. : >> : >> Seems to be a QA problem on your part. : > : > yes.. but I can't do a compile from my mac. (my commit machine). The answer : > is to be rigorous about how I move the patch from the build machine to the : > commit machine. : > : > This is a temporary situation. new infrastructure will let me commit from my : > build machine again. : : I find having a copy of Parallels (or VMWare) around very useful for precisely : this situation -- it means that even when I have only the Mac around I can : easily do a local test build. The various VM packages certainly have their : limitations, but they're far better than nothing. I've always found that no matter how much testing i do, sometimes accidents happen. The only way to be sure is to test, commit and then checkout in a clean tree the change you made and test again... Warner