Date: Mon, 20 Nov 2017 21:57:16 +0000 From: Brooks Davis <brooks@freebsd.org> To: Edward Tomasz Napierala <trasz@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325965 - head/libexec/rtld-elf Message-ID: <20171120215716.GA2442@spindle.one-eyed-alien.net> In-Reply-To: <201711181321.vAIDLM6S028725@repo.freebsd.org> References: <201711181321.vAIDLM6S028725@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 18, 2017 at 01:21:22PM +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Sat Nov 18 13:21:22 2017 > New Revision: 325965 > URL: https://svnweb.freebsd.org/changeset/base/325965 >=20 > Log: > Increase rtld initial memory pool size from 32kB to 128kB. > =20 > The old value was probably fine back in 1998, when that code was import= ed > (although the comments still mention VAX, which was quite obsolete by t= hen); > now, however, it's too small to handle our libc, which results in some > additional calls to munmap/mmap later on. Asking for more virtual addr= ess > space is virtually free, and syscalls are not, thus the change. Not specificaly about this commit, but a general comment: The power-of-2 sized buckets used by this allocator are likely suboptimal both in terms of space use (largely irrelevent in practice) and cache effects (in particular, unnecessicary false sharing of TLS segments). There is probably a fair bit of room for optimization here. -- Brooks --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJaE0+8AAoJEKzQXbSebgfAAhcH/24sopp2YZqH4t8QUOuQrOzE t+7y4BPiFNEACGiPJzdi+CYU3zKkNeZ1oINa8hQk4qJHKh84TgStxt2jbA4i7o15 Qb1VE9InSGiGg6Za96/dzbgH3oQm6leuFAICDQ2GRjucm+F3KwfxwxmQZvmee36S yjfrQTDTaLh99K+e0GBGqaHIzFnDH1XOs8Pzk1L5Mhx9Zr+6FV1jhFwvZTKP3P6M KMtGjz3quNuLky1QGyZzAxDEb45x9Uwm1IAx0iegFptJ5Ewts+hU0NMfymRN7oTe cIYiGfKsUlojchQawml1Uu6a6tlCyvj5VDRBYHQOgzIBbaDnrsntRRmkbDo1aTk= =SUiO -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171120215716.GA2442>