Date: Tue, 28 Feb 1995 18:06:32 -0800 From: Paul Traina <pst@cisco.com> To: "Andrey A. Chernov, Black Mage" <ache@astral.msk.su> Cc: bugs@FreeBSD.org, Serg Vakulenko <vak@zebub.msk.su> Subject: Re: do not implement misc/186 Message-ID: <199503010206.SAA25759@feta.cisco.com> In-Reply-To: Your message of "Wed, 01 Mar 1995 05:02:51 %2B0300." <NRBNzKleF0@astral.msk.su>
next in thread | previous in thread | raw e-mail | index | archive | help
Oh damn. From: "Andrey A. Chernov, Black Mage" <ache@astral.msk.su> Subject: Re: do not implement misc/186 In message <199503010056.QAA21722@feta.cisco.com> Paul Traina writes: >Subject: Re: misc/186: Sendmail incorrectly defines $s macro inside the rule >> #0 This fix already applied long time ago to our sources and you restore it after merging deliver.c changes. >------- Forwarded Message >Date: Tue, 28 Feb 1995 16:33:28 -0800 >From: Eric Allman <eric@cs.Berkeley.EDU> >To: Paul Traina <pst@cisco.com> >cc: sendmail@cs.Berkeley.EDU >Subject: Re: misc/186: Sendmail incorrectly defines $s macro inside the rule >> #0 >I don't believe that is correct fix, since host isn't necessarily >meaningful at that point (e.g., for local mail), and CurHostName >is used for more than setting $s. The 8.7 code has that as just >setting CurHostName = NULL at that point -- you'll notice that it >gets reset later in the code if there is a valid host name. Right, it isn't meaningful just in _that_ point, but becomes meaningful later, so setting it to junk value not helps at all. Just look down into code, it resets later in some places, but not in _all_ cases. What happens if it isn't reset? I can answer: in this case it triggers a bug, since have junk value instead of host value. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199503010206.SAA25759>