From owner-svn-src-head@FreeBSD.ORG  Wed Apr  6 17:29:52 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6371106564A;
	Wed,  6 Apr 2011 17:29:52 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id BC0D38FC19;
	Wed,  6 Apr 2011 17:29:52 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 4420B46B97;
	Wed,  6 Apr 2011 13:29:52 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id C47388A01B;
	Wed,  6 Apr 2011 13:29:51 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Edward Tomasz Napierala <trasz@freebsd.org>
Date: Wed, 6 Apr 2011 13:26:22 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; )
References: <201104061659.p36GxtjJ099011@svn.freebsd.org>
In-Reply-To: <201104061659.p36GxtjJ099011@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201104061326.22743.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Wed, 06 Apr 2011 13:29:51 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r220388 - in head/sys: kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2011 17:29:53 -0000

On Wednesday, April 06, 2011 12:59:55 pm Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Wed Apr  6 16:59:54 2011
> New Revision: 220388
> URL: http://svn.freebsd.org/changeset/base/220388
> 
> Log:
>   Add ucred pointer to the SysV-related memory structures.  This is required
>   for racct.
>   
>   Note that after this commit, ipcs(1) needs to be rebuilt.  Otherwise, it will
>   fail with "ipcs: sysctlbyname: kern.ipc.msqids: Cannot allocate memory".
>   
>   Sponsored by:	The FreeBSD Foundation
>   Reviewed by:	kib (earlier version)

Please use this idiom:

	foo->cred = crhold(bar->cred);

instead of:

	crhold(bar->cred);
	foo->cred = bar->cred;

I think this cleaner in terms of readability and semantics.

-- 
John Baldwin