Date: Sun, 29 Aug 2004 10:10:35 GMT From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68770: [PATCH] mail/qmail-scanner: Add an option to select language Message-ID: <200408291010.i7TAAZvA002379@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/68770; it has been noted by GNATS. From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Volker Stolz <vs@freebsd.org> Cc: FreeBSD-gnats-submit@freebsd.org, =?ISO-8859-1?Q?Cl=E9ment_MOULIN?= <cmoulin@simplerezo.com>, Renato Botelho <renato@galle.com.br>, Pav Lucistnik <pav@FreeBSD.org> Subject: Re: ports/68770: [PATCH] mail/qmail-scanner: Add an option to select language Date: Sun, 29 Aug 2004 12:04:17 +0200 Volker Stolz wrote: > On Sun, Jul 11, 2004 at 04:46:11PM +0200, Cl=E9ment MOULIN wrote: >> This patch is useless. >> Qmail-Scanner use LANG variable from your environnement to "detect" = the >> appropriate language. >> >> Obviously, you can specify it on command line: >> #LANG=3Djp_JP make > > Hm, I'm not sure that this is a good idea either -- this would mean=20= > that > the environment influences the build when using 'sudo'. I just = checked, > export LANG=3Dde; sudo bash -c set | grep LANG reveals that LANG = remains > set. I can't nail you down to specific instructions, but I think this > should be considered rather a bug than a feature. You my two cents: since LANG influences sed, grep and other text=20 processing utilities I'm not sure whether it is a good idea to build=20 ports with LANG set. We might decide to sanitize the environment when=20 building ports should this turn out to cause problems, so I would=20 suggest to either make clear that other languages are unsupported or to=20= make the configuration explicit. Implicit configuration inherited by the=20= build environment is always fragile and should be made explicit. -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408291010.i7TAAZvA002379>