From owner-svn-src-head@FreeBSD.ORG  Tue Nov 11 15:34:07 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 773F789F;
 Tue, 11 Nov 2014 15:34:07 +0000 (UTC)
Received: from mail-pd0-x22a.google.com (mail-pd0-x22a.google.com
 [IPv6:2607:f8b0:400e:c02::22a])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48CDBC88;
 Tue, 11 Nov 2014 15:34:07 +0000 (UTC)
Received: by mail-pd0-f170.google.com with SMTP id z10so10347978pdj.29
 for <multiple recipients>; Tue, 11 Nov 2014 07:34:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=references:mime-version:in-reply-to:content-type
 :content-transfer-encoding:message-id:cc:from:subject:date:to;
 bh=KkIshoCp4R1Lf3R2RGJmUxxIO1AhjIeFLIyHPTNTMoc=;
 b=sdaS16Y1aMnsYApCgr8cBEZc2Jq1IouKARbavEi312p5mzAjT1RjjicveZ3fBN8fOW
 BWIhaE5aOmQZiNtSokOf0tRe28BQKi3ry6HHWrULGrBbPbwzmnnAQk+k74o5ngrkar8/
 mWcF+45z44cnq9o2ZsbtOz6J12pLcXaLTxLA+P53uup5PSH9RiaNlwpwCO/L36MkWlkp
 SKHfIHwLRccLeXwt39qAL4aOCsN7OuzOnTcl09ze4cfWYC/WHlSQD+I3JvQ+WmbK65Yk
 FXRte8l8nwB3XtbQt7tgof8SfGzl9vaAn/uXFSiO1OPOyx9Yif07H78CpDWqW7asuHjs
 pRXg==
X-Received: by 10.68.68.235 with SMTP id z11mr40188869pbt.102.1415720046688;
 Tue, 11 Nov 2014 07:34:06 -0800 (PST)
Received: from [192.168.20.11] (c-98-247-240-204.hsd1.wa.comcast.net.
 [98.247.240.204])
 by mx.google.com with ESMTPSA id b16sm15589675pdl.56.2014.11.11.07.34.05
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 11 Nov 2014 07:34:05 -0800 (PST)
References: <201411110407.sAB47gBT003976@svn.freebsd.org>
 <54621043.9000502@freebsd.org>
Mime-Version: 1.0 (1.0)
In-Reply-To: <54621043.9000502@freebsd.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com>
X-Mailer: iPhone Mail (12B411)
From: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime
Date: Tue, 11 Nov 2014 07:34:04 -0800
To: Andrey Chernov <ache@freebsd.org>
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Garrett Cooper <ngie@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2014 15:34:07 -0000


> On Nov 11, 2014, at 05:33, Andrey Chernov <ache@freebsd.org> wrote:
>=20
>> On 11.11.2014 7:07, Garrett Cooper wrote:
>> Author: ngie
>> Date: Tue Nov 11 04:07:41 2014
>> New Revision: 274365
>> URL: https://svnweb.freebsd.org/changeset/base/274365
>>=20
>> Log:
>>  Revert WiP to contrib/tzcode accidentally committed with r274364
>=20
> This code is wrong in any case, setting EOVERFLOW even in unneeded
> no-error cases like breaking from the loop. See how NetBSD does it
> correctly instead.

Hi!
    I saw your reply earlier but hadn't gotten an opportunity to revise the p=
atch like you suggested. I'll look at the NetBSD code and see if I can adapt=
 it to our copy of tzcode.
Thank you!=