From owner-freebsd-current@FreeBSD.ORG  Tue Sep  9 01:07:48 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9432616A4BF
	for <freebsd-current@freebsd.org>;
	Tue,  9 Sep 2003 01:07:48 -0700 (PDT)
Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 059DD43FE1
	for <freebsd-current@freebsd.org>;
	Tue,  9 Sep 2003 01:07:48 -0700 (PDT)
	(envelope-from DougB@freebsd.org)
Received: from master.dougb.net
	(12-234-22-23.client.attbi.com[12.234.22.23](untrusted sender))
	by comcast.net (rwcrmhc12) with SMTP
	id <20030909080746014009gr3oe>; Tue, 9 Sep 2003 08:07:46 +0000
Date: Tue, 9 Sep 2003 01:07:46 -0700 (PDT)
From: Doug Barton <DougB@FreeBSD.org>
To: Harald Schmalzbauer <h@schmalzbauer.de>
In-Reply-To: <200309090942.17317@harrymail>
Message-ID: <20030909010434.H26496@znfgre.qbhto.arg>
References: <20030909042349.GA686@chihiro.leafy.idv.tw>
	<200309090942.17317@harrymail>
Organization: http://www.FreeBSD.org/
X-message-flag: Outlook -- Not just for spreading viruses anymore!
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-current@freebsd.org
Subject: Re: -pthread deprecated, but when?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Sep 2003 08:07:48 -0000

On Tue, 9 Sep 2003, Harald Schmalzbauer wrote:

> On Tuesday 09 September 2003 06:23, leafy wrote:
> > IMO this deprecation deserves a place in UPDATING. And what are the
> > plans to Do The Right Thing? QT currently does not compile on -current
> > with the -pthread deprecated.

Probably be nice to bump __FreeBSD_version too, just for fun.

> Was port@ informed before the change?

Yes.

> I'm also very interested what the plans are to Do The Right Thing.

The right thing to do is to file a PR when this stuff breaks. This
process will actually be a good thing, since ports should not have been
compiling on -current with -pthread for a long time now.

BTW, several ports have already been fixed, and the fix is not
difficult. I do the following in my ports:

        @ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
        @ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
                -e 's#malloc.h#stdlib.h#g' \
                ${WRKSRC}/configure.Patched > ${WRKSRC}/configure

Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.

HTH,

Doug

-- 

    This .signature sanitized for your protection