From owner-p4-projects@FreeBSD.ORG  Thu Dec 29 18:35:18 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 38D2616A429; Thu, 29 Dec 2005 18:35:17 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D98A516A423
	for <perforce@freebsd.org>; Thu, 29 Dec 2005 18:35:16 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 351BE43D5D
	for <perforce@freebsd.org>; Thu, 29 Dec 2005 18:35:05 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jBTIZ0bt069661
	for <perforce@freebsd.org>; Thu, 29 Dec 2005 18:35:00 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jBTIZ0Am069658
	for perforce@freebsd.org; Thu, 29 Dec 2005 18:35:00 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 29 Dec 2005 18:35:00 GMT
Message-Id: <200512291835.jBTIZ0Am069658@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 88893 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2005 18:35:18 -0000

http://perforce.freebsd.org/chv.cgi?CH=88893

Change 88893 by jhb@jhb_slimer on 2005/12/29 18:34:03

	Actually lock the mutex, duh.

Affected files ...

.. //depot/projects/smpng/sys/modules/crash/crash.c#27 edit

Differences ...

==== //depot/projects/smpng/sys/modules/crash/crash.c#27 (text+ko) ====

@@ -97,6 +97,7 @@
 
 	bzero(&test1_mtx, sizeof(test1_mtx));
 	mtx_init(&test1_mtx, "test1", NULL, MTX_SPIN);
+	mtx_lock_spin(&test1_mtx);
 	error = msleep_spin(&test1_mtx, &test1_mtx, "spincr", 5);
 	printf("msleep_spin returned %d\n", error);
 	kdb_enter("timed out");
@@ -104,6 +105,7 @@
 	error = msleep_spin(&test1_mtx, &test1_mtx, "spincr2", 0);
 	printf("msleep_spin returned %d\n", error);
 	kdb_enter("awoke from spin");
+	mtx_unlock_spin(&test1_mtx);
 	mtx_destroy(&test1_mtx);
 }
 CRASH_EVENT("msleep_spin", msleep_spin_test);