Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Jul 2015 17:14:25 +0000 (UTC)
From:      Zbigniew Bodek <zbb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r285758 - head/sys/arm64/arm64
Message-ID:  <201507211714.t6LHEP04058747@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: zbb
Date: Tue Jul 21 17:14:24 2015
New Revision: 285758
URL: https://svnweb.freebsd.org/changeset/base/285758

Log:
  Add some more explanation to r285752
  
  Add brief commentary to vendor-specific devid function in ITS
  and remove redundant spaces by the way.
  
  Obtained from: Semihalf
  Sponsored by:  The FreeBSD Foundation

Modified:
  head/sys/arm64/arm64/gic_v3_its.c

Modified: head/sys/arm64/arm64/gic_v3_its.c
==============================================================================
--- head/sys/arm64/arm64/gic_v3_its.c	Tue Jul 21 16:53:45 2015	(r285757)
+++ head/sys/arm64/arm64/gic_v3_its.c	Tue Jul 21 17:14:24 2015	(r285758)
@@ -1423,20 +1423,24 @@ its_get_devid_thunder(device_t pci_dev)
 		    bsf);
 	/* PEM otherwise */
 	} else {
-		/* PEM number is equal to domain */
+		/* PEM (PCIe MAC/root complex) number is equal to domain */
 		pem = pci_get_domain(pci_dev);
 
-		/* Hardcode appropriate PEM numbers */
-		if (pem < 3 )
+		/*
+		 * Set appropriate device ID (passed by the HW along with
+		 * the transaction to memory) for different root complex
+		 * numbers using hard-coded domain portion for each group.
+		 */
+		if (pem < 3)
 			return ((0x1 << PCI_RID_DOMAIN_SHIFT) | bsf);
 
-		if (pem < 6 )
+		if (pem < 6)
 			return ((0x3 << PCI_RID_DOMAIN_SHIFT) | bsf);
 
-		if (pem < 9 )
+		if (pem < 9)
 			return ((0x9 << PCI_RID_DOMAIN_SHIFT) | bsf);
 
-		if (pem < 12 )
+		if (pem < 12)
 			return ((0xB << PCI_RID_DOMAIN_SHIFT) | bsf);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201507211714.t6LHEP04058747>