From owner-freebsd-audit Sat Nov 11 11:15:34 2000 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 9C94237B479 for ; Sat, 11 Nov 2000 11:15:32 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1000) id 622E41360E; Sat, 11 Nov 2000 14:15:32 -0500 (EST) Date: Sat, 11 Nov 2000 14:15:32 -0500 From: Chris Faulhaber To: Warner Losh Cc: freebsd-audit@FreeBSD.ORG Subject: Re: config(8) patch Message-ID: <20001111141532.A8166@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , Warner Losh , freebsd-audit@FreeBSD.ORG References: <200011111904.eABJ41G31684@billy-club.village.org> <20001111111408.A28197@earth.causticlabs.com> <200011111904.eABJ41G31684@billy-club.village.org> <200011111909.eABJ91G31777@billy-club.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200011111909.eABJ91G31777@billy-club.village.org>; from imp@village.org on Sat, Nov 11, 2000 at 12:09:01PM -0700 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Nov 11, 2000 at 12:09:01PM -0700, Warner Losh wrote: > In message <200011111904.eABJ41G31684@billy-club.village.org> Warner Losh writes: > : In message <20001111111408.A28197@earth.causticlabs.com> Chris Faulhaber writes: > : : 2) allocate [MAXPATHLEN + 1] to ensure room for MAXPATHLEN and '\0' > : > : MAXPATHLEN includes the trailing NUL. At least that's what my brain > : is telling me bde told me after proposing similar changes to another > : part of the tree years ago. > > Looking at intro(2), we see: > > 63 ENAMETOOLONG File name too long. A component of a path name exceeded > 255 (MAXNAMELEN) characters, or an entire path name exceeded 1023 > (MAXPATHLEN-1) characters. > As a side note, there are a few programs in the tree that use MAXPATHLEN + 1 (I think newsyslog.c confused me :). -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message