From owner-freebsd-ports-bugs@freebsd.org Mon Jan 11 10:16:09 2021 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 233224D3D70 for ; Mon, 11 Jan 2021 10:16:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DDqNn0Jfdz3GMh for ; Mon, 11 Jan 2021 10:16:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 08D444D3EC7; Mon, 11 Jan 2021 10:16:09 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 089B34D3DF0 for ; Mon, 11 Jan 2021 10:16:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DDqNm6k05z3G81 for ; Mon, 11 Jan 2021 10:16:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D993118E32 for ; Mon, 11 Jan 2021 10:16:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 10BAG8Lo023141 for ; Mon, 11 Jan 2021 10:16:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 10BAG8On023140 for ports-bugs@FreeBSD.org; Mon, 11 Jan 2021 10:16:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 251153] net/rdesktop 1.9.0 core dumps Date: Mon, 11 Jan 2021 10:16:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 10:16:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251153 --- Comment #9 from rozhuk.im@gmail.com --- (In reply to Ivan from comment #8) I found in mail list that gnutls_x509_crt_get_fingerprint() fails with -72 = for rdesktop. Typical usage for gnutls_x509_crt_get_fingerprint(): int error; uint8_t digest[1024]; size_t digest_size; digest_size =3D sizeof(digest); error =3D gnutls_x509_crt_get_fingerprint(crt_list[0], GNUTLS_DIG_MD5, digest, &digest_size); on error digest_size not changed. I am does not see rdesktop code, but suspect that it does not proper handle error for gnutls_x509_crt_get_fingerprint(). Probably more proper fix would be add error handler and set digest_size to zero: error =3D gnutls_x509_crt_get_fingerprint(crt_list[0], GNUTLS_DIG_MD5, digest, &digest_size); if (0 !=3D error) { digest_size =3D 0; } --=20 You are receiving this mail because: You are the assignee for the bug.=