From owner-cvs-src@FreeBSD.ORG Wed Jun 7 17:47:44 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8358C16DCCE; Wed, 7 Jun 2006 15:24:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A25043D48; Wed, 7 Jun 2006 15:24:29 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [192.168.1.102] (h10.164.165.72.cable.slda.cablerocket.net [72.165.164.10] (may be forged)) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k57FOREY069508; Wed, 7 Jun 2006 11:24:28 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Gleb Smirnoff Date: Wed, 7 Jun 2006 11:23:51 -0400 User-Agent: KMail/1.9.1 References: <200606071226.k57CQNvK018193@repoman.freebsd.org> <200606071045.39131.john@baldwin.cx> In-Reply-To: <200606071045.39131.john@baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606071123.52816.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [66.23.211.162]); Wed, 07 Jun 2006 11:24:28 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1518/Wed Jun 7 09:10:04 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/dc if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2006 17:47:45 -0000 On Wednesday 07 June 2006 10:45, John Baldwin wrote: > On Wednesday 07 June 2006 08:26, Gleb Smirnoff wrote: > > glebius 2006-06-07 12:26:23 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/dc if_dc.c if_dcreg.h > > Log: > > Add device IDs for Linksys PCMPC200 Cardbus card. > > > > PR: kern/75582 > > Submitted by: Gary Palmer > > This doesn't work because you didn't handle the card in attach() and it > probably worked by accident prior to my latest rounds of dc cleanups because > attach() only checked half the PCI device ID before I fixed it. The patches > on hackers@ for this that I planned to fixup to do this add two new device > IDs not just one. :) > > I think you just need to add a 'case DC_DEVID(..., ...):' line to the > appropriate entry. The patches on hackers let you know which entry in > attach() they need to be added to. Specifically, look at www.freebsd.org/~jhb/patches/dc_linksys.patch which is relative to HEAD. -- John Baldwin